Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3CPointerEvents: include screen coordinates in pointer events #38222

Closed
wants to merge 3 commits into from

Conversation

adanoff
Copy link

@adanoff adanoff commented Jul 6, 2023

Summary:
Changelog: [Android] [Fixed] - W3CPointerEvents: include screen coordinates in pointer events

The spec says there should be properties on mouse events (and hence pointer events) indicating the screen coordinates of the event (i.e. coords relative to screen of the device).

This change adds those properties.

Reviewed By: javache

Differential Revision: D47162962

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jul 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47162962

@analysis-bot
Copy link

analysis-bot commented Jul 6, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,000,503 +200
android hermes armeabi-v7a 8,254,579 +185
android hermes x86 9,509,612 +156
android hermes x86_64 9,355,420 +223
android jsc arm64-v8a 9,614,023 +375
android jsc armeabi-v7a 8,740,662 +390
android jsc x86 9,700,984 +377
android jsc x86_64 9,947,537 +380

Base commit: f6c91bf
Branch: main

Alex Danoff added 3 commits July 6, 2023 09:00
Differential Revision: D47162963

fbshipit-source-id: 83853238049dc64b699eabc0dc97da69d4c069ae
Differential Revision: D47230953

fbshipit-source-id: b6b3159b1520060a9aedb035c6605de3c93d83d1
…ook#38222)

Summary:
Pull Request resolved: facebook#38222

Changelog: [Android] [Fixed] - W3CPointerEvents: include screen coordinates in pointer events

The [spec](https://www.w3.org/TR/uievents/#idl-mouseevent) says there should be properties on mouse events (and hence pointer events) indicating the screen coordinates of the event (i.e. coords relative to screen of the device).

This change adds those properties.

Reviewed By: javache

Differential Revision: D47162962

fbshipit-source-id: 59361c4032b6aa0204b7f8d09309cb3f3a25616d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47162962

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3460ff5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants