New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase #38256

Closed

apuruni wants to merge 1 commit into facebook:main from apuruni:export-D47313501

Contributor

apuruni commented Jul 8, 2023

Summary:
Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.

Without this fix, app crashes during launch because of :
SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts

Differential Revision: D47313501

facebook-github-bot added CLA Signed p: Facebook Partner fb-exported labels

Contributor

facebook-github-bot commented Jul 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47313501

apuruni added a commit to apuruni/react-native that referenced this pull request


          For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED …

0cf2283

…flag support in DevSupportManagerBase (facebook#38256)

Summary:
Pull Request resolved: facebook#38256

Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.

Without this fix, app crashes during launch because of :
```SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts```

Changelog:
[Targeting SDK 34] Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase

Differential Revision: D47313501

fbshipit-source-id: 67003fbba3bc46575247a3d51b4dc5705addaf56

apuruni force-pushed the export-D47313501 branch from efd0b7c to 0cf2283 Compare

July 8, 2023 08:16

Contributor

facebook-github-bot commented Jul 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47313501

apuruni added a commit to apuruni/react-native that referenced this pull request


          For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED …

56c35be

…flag support in DevSupportManagerBase (facebook#38256)

Summary:
Pull Request resolved: facebook#38256

Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.

Without this fix, app crashes during launch because of :
```SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts```

Changelog:
[Targeting SDK 34] Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase

Differential Revision: D47313501

fbshipit-source-id: d14fb6ec2134e02fb910b61a7d583df7adce67b9

Contributor

facebook-github-bot commented Jul 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47313501

apuruni force-pushed the export-D47313501 branch from 0cf2283 to 56c35be Compare

July 8, 2023 08:25

analysis-bot commented Jul 8, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	9,001,916	+0
android	hermes	armeabi-v7a	8,255,977	-2
android	hermes	x86	9,511,054	-1
android	hermes	x86_64	9,356,939	+0
android	jsc	arm64-v8a	9,614,950	+0
android	jsc	armeabi-v7a	8,741,582	-1
android	jsc	x86	9,701,900	-4
android	jsc	x86_64	9,948,458	+0

Base commit: c82f2e9
Branch: main

apuruni added a commit to apuruni/react-native that referenced this pull request


          For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED …

31bc25b

…flag support in DevSupportManagerBase (facebook#38256)

Summary:
Pull Request resolved: facebook#38256

Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.

Without this fix, app crashes during launch because of :
```SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts```

Changelog:
[Targeting SDK 34] Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase

Differential Revision: D47313501

fbshipit-source-id: c698bda10900e7a4b31c697b1fd2ab1b540fe88c

apuruni force-pushed the export-D47313501 branch from 56c35be to 31bc25b Compare

July 8, 2023 15:45

Contributor

facebook-github-bot commented Jul 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47313501

apuruni added a commit to apuruni/react-native that referenced this pull request


          For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED …

e57a81c

…flag support in DevSupportManagerBase (facebook#38256)

Summary:
Pull Request resolved: facebook#38256

Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.

Without this fix, app crashes during launch because of :
```SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts```

Changelog:
[Targeting SDK 34] Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase

Differential Revision: D47313501

fbshipit-source-id: bb1f4522edc4fe3f962503c9cce8a88e73d505cc

apuruni force-pushed the export-D47313501 branch from 31bc25b to e57a81c Compare

July 8, 2023 15:52

Contributor

facebook-github-bot commented Jul 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47313501


          For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED …

f14da92

…flag support in DevSupportManagerBase (facebook#38256)

Summary:
Pull Request resolved: facebook#38256

Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.

Without this fix, app crashes during launch because of :
```SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts```

Changelog:
[Targeting SDK 34] Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase

Reviewed By: javache

Differential Revision: D47313501

fbshipit-source-id: 0fade223c8629a2050dc440fd975da0bc9ee94aa

Contributor

facebook-github-bot commented Jul 10, 2023

This pull request was exported from Phabricator. Differential Revision: D47313501

apuruni force-pushed the export-D47313501 branch from e57a81c to f14da92 Compare

July 10, 2023 11:32

facebook-github-bot closed this in

177d97d

github-actions bot commented Jul 10, 2023

This pull request was successfully merged by @apuruni in 177d97d.

^{When will my fix make it into a release? | Upcoming Releases}

github-actions bot added the Merged label

Contributor

facebook-github-bot commented Jul 10, 2023

This pull request has been merged in 177d97d.

dominikwagner mentioned this pull request

Android 14 Broadcast Receiver flag #37769

Closed

lunaleaps pushed a commit that referenced this pull request


          For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED …

3cf94df

…flag support in DevSupportManagerBase (#38256)

Summary:
Pull Request resolved: #38256

Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.

Without this fix, app crashes during launch because of :
```SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts```

Changelog:
[Targeting SDK 34] Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase

Reviewed By: javache

Differential Revision: D47313501

fbshipit-source-id: 12e8299559d08b4ff87b4bdabb0a29d27763c698

This was referenced Aug 10, 2023

[LOCAL] Fix Ruby Tests for 0.72 #38919

Closed

[LOCAL] Add script poll maven #38980

Merged

This was referenced Oct 11, 2023

cipolleschi/fix CI #40793

Merged

[Local] Fix CI for 0.72, with Acitve Support and Xcode15 #40855

Merged

axinvd mentioned this pull request

Android 14 support wix/react-native-navigation#7801

Merged

This was referenced Nov 1, 2023

[RN][CI]Update node installation on debian (0.72) #41276

Merged

[RN][CI]Update node installation on debian (0.71) #41277

Merged

AndyG added a commit to discord/react-native that referenced this pull request


          added android 14 support to DevSupportManagerBase.java. for more info…

72576a3

…, see facebook#38256

AndyG mentioned this pull request

Adds Android 14 support to DevSupportManagerBase discord/react-native#47

Merged

yogevbd pushed a commit to wix/react-native-navigation that referenced this pull request


          Android 14 support (#7801)

58edd09

From react native [pr](facebook/react-native#38256)
> Summary:
> Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
> https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.
> 
> Without this fix, app crashes during launch because of :
> SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts

thuongtv-vn commented Nov 8, 2023

Hi All,

Can we create patch file for those changes?

stevenpetryk mentioned this pull request

Avoid using Xcode 15's gcc when compiling glog discord/react-native#48

Merged

cipolleschi mentioned this pull request

[RN][iOS] Improve Swift support for 3rd party libs #42075

Merged

cipolleschi mentioned this pull request

[RN][iOS] Disable Bitcode for Hermes #42142

Merged

Girum commented Jan 4, 2024

Hi! Ai updated from react native from 0.70.6 to 0.72.8, and the error persists. How to resolve?

This was referenced Jan 8, 2024

[Local][RN][General] 0.72 - migrate boost away from JFrog #42175

Merged

[0.71][RN][General] Migrate boost download url away from JFrog #42177

Merged

[RN][iOS] Fix symbol not found _jump_fcontext with use_frameworks! #42228

Merged

[RN][iOS] Fix symbol not found _jump_fcontext with use_frameworks! #42229

Merged

[RN][iOS] Fix min ios version regression and update podfile.lock #42232

Closed

This was referenced Feb 28, 2024

[RN][IOS] Fix flags for new arch #43240

Merged

[RN][iOS]Rename BUILD_FROM_SOURCE to RCT_BUILD_HERMES_FROM_SOURCE #43247

Merged

[RN][iOS][0.72] Fix flipper for Xcode 15.3 #43344

Merged

[RN][iOS][0.71] Fix flipper for Xcode 15.3 #43345

Merged

Flewp pushed a commit to discord/react-native that referenced this pull request


          added android 14 support to DevSupportManagerBase.java. for more info…

ebff628

…, see facebook#38256

cipolleschi mentioned this pull request

cipolleschi/fix yoga archive 0.71 #43895

Closed

cipolleschi mentioned this pull request

[iOS][Privacy Manifest] Set up privacy manifest for React Native 0.71 #44281

Merged

cipolleschi mentioned this pull request

[CI] Move machines to M1 for 0.72 #45215

Closed

1t5j0y added a commit to avniproject/avni-client that referenced this pull request


          #1455 | targetSdk 34

cf3f2d3

- building using gradle 8 throws errors if any dependencies have package name specified in AndroidManifest.xml
-- Addressed by patching AndroidManifest.xml of each affected dependency to remove package and added namespace to corresponding build.gradle
-- For amazon-cognito-identity-js, addressed by upgrading dependency to a later patch version with this change
- react-native-vector-icons needed additional patching for other breaking issues in gradle 8 - oblador/react-native-vector-icons#1588
- react-native-video upgraded from 5.2.0 to 5.2.1 to fix TheWidlarzGroup/react-native-video#3160.
-- Changes in existing patch for 5.2.0 are already included in react-native-video release 5.2.1
- react-native upgraded from 0.72.3 to 0.72.8 to get fix for facebook/react-native#38256 which was causing crash on launch
-- Additionally, did an override of registerReceiver in MainApplication.java facebook/react-native#41288

chirag-blueed commented Aug 2, 2024

Which version of React Native includes these features? We are using 0.68.2, and I am still facing the issue. Can someone guide here?

chrisbobbe pushed a commit to zulip/react-native that referenced this pull request


          For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED …

dab6c1e

…flag support in DevSupportManagerBase (facebook#38256)

Summary:
Pull Request resolved: facebook#38256

Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.

Without this fix, app crashes during launch because of :
```SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts```

Changelog:
[Targeting SDK 34] Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase

Reviewed By: javache

Differential Revision: D47313501

fbshipit-source-id: 12e8299559d08b4ff87b4bdabb0a29d27763c698

(Cherry picked from commit 177d97d to support targetSdkVersion = 34.)

chrisbobbe pushed a commit to zulip/react-native that referenced this pull request


          For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED …

5c36f10

…flag support in DevSupportManagerBase (facebook#38256)

Summary:
Pull Request resolved: facebook#38256

Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.

Without this fix, app crashes during launch because of :
```SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts```

Changelog:
[Targeting SDK 34] Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase

Reviewed By: javache

Differential Revision: D47313501

fbshipit-source-id: 12e8299559d08b4ff87b4bdabb0a29d27763c698

(Cherry picked from commit 177d97d to support targetSdkVersion = 34.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner