Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo App.test.tsx #38524

Closed

Conversation

IslamRustamov
Copy link
Contributor

Summary:

There was a typo in App.test.tsx, that I noticed when tried to upgrade from 0.71 to 0.72

Changelog:

Fixed small typo from shiped to shipped

Pick one each for the category and type tags:

[GENERAL] [FIXED]

@github-actions
Copy link

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 299b2da

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,842,225 +0
android hermes armeabi-v7a 8,151,628 +2
android hermes x86 9,347,921 +0
android hermes x86_64 9,190,743 -1
android jsc arm64-v8a 9,454,282 -1
android jsc armeabi-v7a 8,635,603 +1
android jsc x86 9,537,282 +1
android jsc x86_64 9,780,639 +0

Base commit: 2d3348e
Branch: main

@github-actions github-actions bot added the Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. label Jul 20, 2023
@facebook-github-bot
Copy link
Contributor

Hi @IslamRustamov!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 20, 2023
@facebook-github-bot
Copy link
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

This pull request was successfully merged by @IslamRustamov in 4aa53d2.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Jul 24, 2023
@facebook-github-bot
Copy link
Contributor

@NickGerleman merged this pull request in 4aa53d2.

billnbell pushed a commit to billnbell/react-native that referenced this pull request Jul 29, 2023
Summary:
There was a typo in App.test.tsx, that I noticed when tried to upgrade from 0.71 to 0.72

## Changelog:

Fixed small typo from *shiped* to *shipped*

Pick one each for the category and type tags:

[GENERAL] [FIXED]

Pull Request resolved: facebook#38524

Reviewed By: cortinico

Differential Revision: D47695088

Pulled By: NickGerleman

fbshipit-source-id: 9f74c7f891927be6c0c0f522f0cd51b022fb54f1
billnbell pushed a commit to billnbell/react-native that referenced this pull request Jul 29, 2023
Summary:
There was a typo in App.test.tsx, that I noticed when tried to upgrade from 0.71 to 0.72

## Changelog:

Fixed small typo from *shiped* to *shipped*

Pick one each for the category and type tags:

[GENERAL] [FIXED]

Pull Request resolved: facebook#38524

Reviewed By: cortinico

Differential Revision: D47695088

Pulled By: NickGerleman

fbshipit-source-id: 9f74c7f891927be6c0c0f522f0cd51b022fb54f1
billnbell pushed a commit to billnbell/react-native that referenced this pull request Jul 29, 2023
Summary:
There was a typo in App.test.tsx, that I noticed when tried to upgrade from 0.71 to 0.72

## Changelog:

Fixed small typo from *shiped* to *shipped*

Pick one each for the category and type tags:

[GENERAL] [FIXED]

Pull Request resolved: facebook#38524

Reviewed By: cortinico

Differential Revision: D47695088

Pulled By: NickGerleman

fbshipit-source-id: 9f74c7f891927be6c0c0f522f0cd51b022fb54f1
blakef pushed a commit to blakef/template that referenced this pull request Feb 28, 2024
Summary:
There was a typo in App.test.tsx, that I noticed when tried to upgrade from 0.71 to 0.72

## Changelog:

Fixed small typo from *shiped* to *shipped*

Pick one each for the category and type tags:

[GENERAL] [FIXED]

Pull Request resolved: facebook/react-native#38524

Reviewed By: cortinico

Differential Revision: D47695088

Pulled By: NickGerleman

fbshipit-source-id: 9f74c7f891927be6c0c0f522f0cd51b022fb54f1

Original: facebook/react-native@4aa53d2
blakef pushed a commit to react-native-community/template that referenced this pull request Feb 29, 2024
Summary:
There was a typo in App.test.tsx, that I noticed when tried to upgrade from 0.71 to 0.72

## Changelog:

Fixed small typo from *shiped* to *shipped*

Pick one each for the category and type tags:

[GENERAL] [FIXED]

Pull Request resolved: facebook/react-native#38524

Reviewed By: cortinico

Differential Revision: D47695088

Pulled By: NickGerleman

fbshipit-source-id: 9f74c7f891927be6c0c0f522f0cd51b022fb54f1

Original-Commit: facebook/react-native@4aa53d2
blakef pushed a commit to react-native-community/template that referenced this pull request Feb 29, 2024
Summary:
There was a typo in App.test.tsx, that I noticed when tried to upgrade from 0.71 to 0.72

## Changelog:

Fixed small typo from *shiped* to *shipped*

Pick one each for the category and type tags:

[GENERAL] [FIXED]

Pull Request resolved: facebook/react-native#38524

Reviewed By: cortinico

Differential Revision: D47695088

Pulled By: NickGerleman

fbshipit-source-id: 9f74c7f891927be6c0c0f522f0cd51b022fb54f1

Original-Commit: facebook/react-native@4aa53d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants