Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(codegen): add getLiteralValue in parser #38651

Closed
wants to merge 1 commit into from

Conversation

Zwem
Copy link
Contributor

@Zwem Zwem commented Jul 27, 2023

Summary:

[Codegen 130] This PR add a getLiteralValue function to the Parser interface, which returns the literal value of an union represented, given an option. as requested on #34872

Changelog:

[INTERNAL] [ADDED] - Add getLiteralValue function to codegen Parser

Test Plan:

Run yarn jest react-native-codegen and ensure CI is green

Signed-off-by: Denis <denis.vasilyeu@gmail.com>
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 27, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,883,356 +2
android hermes armeabi-v7a 7,934,153 +0
android hermes x86 9,280,422 -1
android hermes x86_64 9,183,545 +1
android jsc arm64-v8a 9,473,065 +2
android jsc armeabi-v7a 8,416,419 +1
android jsc x86 9,455,816 +2
android jsc x86_64 9,772,024 +1

Base commit: e37e530
Branch: main

@Zwem
Copy link
Contributor Author

Zwem commented Jul 31, 2023

@cipolleschi @rshest PR is ready for review but needs re run. circleci: test_windows (failed with 500 error)

@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

This pull request was successfully merged by @Zwem in 6d5be26.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Jul 31, 2023
@Zwem Zwem deleted the codegen-130 branch August 1, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants