Deprecate ReactPackage.createNativeModules recommending using getModule instead #39339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48992719 |
Base commit: 59e6b11 |
|
This pull request was exported from Phabricator. Differential Revision: D48992719 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 8, 2023
…le instead (facebook#39339) Summary: Pull Request resolved: facebook#39339 Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native changelog: [Android][Changed] Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native Reviewed By: cortinico Differential Revision: D48992719 fbshipit-source-id: ba8aebcd9d737daae6a8023210d424a7f142afae
mdvacca
force-pushed
the
export-D48992719
branch
from
0d18d1d to
03fd31d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48992719 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 8, 2023
…le instead (facebook#39339) Summary: Pull Request resolved: facebook#39339 Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native changelog: [Android][Changed] Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native Reviewed By: cortinico Differential Revision: D48992719 fbshipit-source-id: 13e9345dffd2d1216eb20679492dff6306ca3348
mdvacca
force-pushed
the
export-D48992719
branch
from
03fd31d to
c4f7a37
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48992719 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 8, 2023
…le instead (facebook#39339) Summary: Pull Request resolved: facebook#39339 Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native changelog: [Android][Changed] Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native Reviewed By: cortinico Differential Revision: D48992719 fbshipit-source-id: e5844e4d5a59e63d5a394b6eda05828f4d5284d2
mdvacca
force-pushed
the
export-D48992719
branch
from
c4f7a37 to
fcb3890
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48992719 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 11, 2023
…le instead (facebook#39339) Summary: Pull Request resolved: facebook#39339 Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native changelog: [Android][Changed] Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native Reviewed By: cortinico Differential Revision: D48992719 fbshipit-source-id: 3d19b23226a1378922fe56b250a02a793d3b5cd2
mdvacca
force-pushed
the
export-D48992719
branch
from
fcb3890 to
3edeed7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48992719 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 13, 2023
…le instead (facebook#39339) Summary: Pull Request resolved: facebook#39339 Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native changelog: [Android][Changed] Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native Reviewed By: cortinico Differential Revision: D48992719 fbshipit-source-id: 9c863f25086c459ed374bd0c57868e4bbdbde196
mdvacca
force-pushed
the
export-D48992719
branch
from
3edeed7 to
ae9c3f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48992719 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 13, 2023
…le instead (facebook#39339) Summary: Pull Request resolved: facebook#39339 Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native changelog: [Android][Changed] Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native Reviewed By: cortinico Differential Revision: D48992719 fbshipit-source-id: 2ef8676c90c28c8e6759b614db54824c8271d3ae
mdvacca
force-pushed
the
export-D48992719
branch
from
ae9c3f3 to
f6c89aa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48992719 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 14, 2023
…le instead (facebook#39339) Summary: Pull Request resolved: facebook#39339 Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native changelog: [Android][Changed] Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native Reviewed By: cortinico Differential Revision: D48992719 fbshipit-source-id: 5a64cb8ee10e10315e72f10b402f377951e3e3d9
mdvacca
force-pushed
the
export-D48992719
branch
from
f6c89aa to
3bdc0d2
Compare
Differential Revision: D48992474 fbshipit-source-id: dc401c5ae587c3c3359d620a1d86d28da6cedb05
Differential Revision: D48992720 fbshipit-source-id: d41f89916ce5df728b661115ba3cc674432c7b84
Summary: In this diff I'm introducing the new DeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in OSS. changelog: [Android] Introduce DeprecatedInNewArchitecture annotation Differential Revision: D49068234 fbshipit-source-id: 2c8d96b7a3e31ab5f48672491bdc4a6f2455ecac
|
This pull request was exported from Phabricator. Differential Revision: D48992719 |
…le instead (facebook#39339) Summary: Pull Request resolved: facebook#39339 Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native changelog: [Android][Changed] Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native Reviewed By: cortinico Differential Revision: D48992719 fbshipit-source-id: 3ec4ec565f240b5cc1d8e76c5c39ef95a0213068
mdvacca
force-pushed
the
export-D48992719
branch
from
3bdc0d2 to
9d938c0
Compare
|
This pull request has been merged in 33181ef. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native
changelog: [Android][Changed] Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native
Differential Revision: D48992719