Breaking: Remove "UseLegacyStretchBehaviour" functions #39372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: f3addeaa4984914993ba57633c85b7aad7cecac7
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 10, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: b7261d567f74be946da8138c82a28e45eacaf121
NickGerleman
force-pushed
the
export-D49131250
branch
from
d3051b3
to
672032d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 10, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: cf08e4d2412fbff08fa88d882f584d275b856d6d
NickGerleman
force-pushed
the
export-D49131250
branch
from
672032d
to
2b308ce
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: 97e94d374a5f5e1a8654d8a519aab1eed4bebf8a
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
Base commit: a2fb46e |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 10, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: 441a42564d00c96db0bad517b4af8ae02a858717
NickGerleman
force-pushed
the
export-D49131250
branch
from
2b308ce
to
43829cd
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: cf6101bd801d72ab7e6a67e65590e03f25a80fa8
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 10, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: 39dbeb7c21e37333872f77fcfc5c75f458991c67
NickGerleman
force-pushed
the
export-D49131250
branch
from
43829cd
to
115cc3d
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: 4e6acfbaa1cd26c03bb7db90ba26529fe7c3f48b
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: cdbb51e026df1fee51ee76bdb7b2724a425a51dd
NickGerleman
force-pushed
the
export-D49131250
branch
from
115cc3d
to
603fe46
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 11, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: eb6e0b254b1c40151e4dde38ce375a563e33ee6f
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: b6d5e3a7109e7ecd4163a7986cb522e14ab6c1d7
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: 9f4fcd3dcea2757130a048197643db78d6ac9761
NickGerleman
force-pushed
the
export-D49131250
branch
from
603fe46
to
9753cfd
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: 89d91e672f3f92c1660aaaee2186c6b384eaddaa
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
force-pushed
the
export-D49131250
branch
from
9753cfd
to
65fd2a9
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: 4a8e339abe8cc6329546f832d972a40d077de0ab
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: 178828b49f1e4a6dc0620669b7cb3bbc522b9444
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: abd366ecb8d9fab7a49921a7fe44dc25cb9430b2
NickGerleman
force-pushed
the
export-D49131250
branch
from
65fd2a9
to
50c2bd5
Compare
Summary: This changes public Yoga API to in more places accept const structures where before they required mutable ones. This tries to avoid more breaking changes yet, e.g. changing callbacks to require clients do not modify nodes when they are passed for logging. We also don't have const variants for returning child structures which would allow mutation of dependencies of the const object. These would need new names under the public API, since we do not have operator overloading in C. Differential Revision: D49130412 fbshipit-source-id: 85567669e1014da755dfdcd822294ceb392073be
Summary: X-link: facebook/yoga#1369 Pull Request resolved: facebook#39370 This fixes const-correctness of callbacks (e.g. not letting a logger function modify nodes during layout). This helps us to continue to fix const-correctness issues inside of Yoga. This change is breaking to the public API, since it requires a change in signature passed to Yoga. Changelog: [Internal] Differential Revision: https://internalfb.com/D49130714 fbshipit-source-id: a9a533fb900da1de9e0de1008a653e46fe3eab82
Summary: Yoga's public API exposes indices most often as `uint32_t`, with exception of clone callbacks which are `int32_t`. Yoga internally represents these indices as `size_t` when dealing with the child vector, and this is the true index. This changes the API to consistently be `size_t`. This should not be breaking for most users, but will cause breaks where: 1. Users set a clone node callback (I think this should be rare. RN uses it, but only because it relies on a separate private API). 2. Callers of `YGNodeGetChildCount()` are assigning to an int with less width than `size_t` and have strong warnings enabled. 3. Using a newer Yoga binary with older source, since we are not preserving ABI compatibility (Yoga in general does not aim to be ABI stable between major versions, only ABI safe for a given set of sources). Differential Revision: D49130914 fbshipit-source-id: 0fccf73fa696e94db5a9cbf3559a5be5d663f70b
Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: f433288c6175b8b49177fb9113021381e4c68377
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: a85f4355acf708e4e68a9bed69550aed0dc934cc
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: 1959e0a330f49ec4ce99303b66354aafb20aa26b
NickGerleman
force-pushed
the
export-D49131250
branch
from
50c2bd5
to
b95e50f
Compare
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: cc1d4e8b179697b9a11a685f4fc4e9d36e1a26a0
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: #1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: cc1d4e8b179697b9a11a685f4fc4e9d36e1a26a0
|
This pull request has been merged in c35ff13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them.
Differential Revision: D49131250