Deprecate default_flags in Podfile #39389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49147290 |
Base commit: b955d8d |
|
This pull request was exported from Phabricator. Differential Revision: D49147290 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#39389 The Podfile of the Template is using a function called `get_default_flags` to get the default flags. Its behavior is duplicated in both the default value of the `use_react_native!` function and in the body of the same function, making that helper actually redundant. In this change, we are deprecating it so we can remove it in 0.74 with no breakages. ## Changelog: [iOS][Deprecated] - Deprecate `get_default_flags` in Ruby scripts Reviewed By: dmytrorykun Differential Revision: D49147290 fbshipit-source-id: 2f9f024084b3b922582d70e7baccb23a389b0caa
cipolleschi
force-pushed
the
export-D49147290
branch
from
5e9b219 to
6b57f7c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49147290 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: facebook#39389 The Podfile of the Template is using a function called `get_default_flags` to get the default flags. Its behavior is duplicated in both the default value of the `use_react_native!` function and in the body of the same function, making that helper actually redundant. In this change, we are deprecating it so we can remove it in 0.74 with no breakages. ## Changelog: [iOS][Deprecated] - Deprecate `get_default_flags` in Ruby scripts Reviewed By: dmytrorykun Differential Revision: D49147290 fbshipit-source-id: 86c30529473effb91b4e23e20c78957ae7400f10
cipolleschi
force-pushed
the
export-D49147290
branch
from
6b57f7c to
536bf20
Compare
…cebook#39387) Summary: Pull Request resolved: facebook#39387 This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Differential Revision: https://internalfb.com/D49145515 fbshipit-source-id: a9a5afd02480f8a819112d2162885184d5038f89
Summary: This diff introduce an helper to read the content of the React Native package of json from ruby. ## Changelog: [iOS][Added] - Add helper to read the package.json from the cocoapods script. Differential Revision: D49146946 fbshipit-source-id: b6552e2d22d7365f2748b51a6675f2086f2e66d2
Summary: Pull Request resolved: facebook#39389 The Podfile of the Template is using a function called `get_default_flags` to get the default flags. Its behavior is duplicated in both the default value of the `use_react_native!` function and in the body of the same function, making that helper actually redundant. In this change, we are deprecating it so we can remove it in 0.74 with no breakages. ## Changelog: [iOS][Deprecated] - Deprecate `get_default_flags` in Ruby scripts Reviewed By: dmytrorykun Differential Revision: D49147290 fbshipit-source-id: c97279008c4690882d1edbbce396ce8d67629452
|
This pull request was exported from Phabricator. Differential Revision: D49147290 |
cipolleschi
force-pushed
the
export-D49147290
branch
from
536bf20 to
b060df2
Compare
|
This pull request has been merged in f60b9f6. |
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Sep 13, 2023
* main: (1012 commits) Add simple constructor for JSError (facebook#39415) Breaking: per-node pointScaleFactor (facebook#39403) Implement "tickleJS" for Hermes (facebook#39289) Add thread idle indicator (facebook#39206) Unblock `yarn android` on main (facebook#39413) Remove Codegen buck-oss scripts as they're unused (facebook#39422) Immediately dispatch events to the shared C++ infrastructure to support interruptability (facebook#39380) Fix race condition in Binding::reportMount (facebook#39420) Clone free state progression (facebook#39357) fix: return the correct default trait collection (facebook#38214) Read the React Native version and set the new arch flag properly (facebook#39388) Deprecate default_flags in Podfile (facebook#39389) Create Helper to read the package.json from Cocoapods (facebook#39390) Create helper to enforce the New Arch enabled for double released (facebook#39387) Remove layoutContext Drilling (facebook#39401) Remove JNI Binding usage of layoutContext (facebook#39402) Extract isBaselineLayout() (facebook#39400) Refactor and separate layout affected nodes react marker (facebook#39249) Bump AGP to 8.1.1 (facebook#39392) Fix broken Gradle Sync when opening the project with Android Studio (facebook#39412) ...
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: Pull Request resolved: facebook/react-native#39389 The Podfile of the Template is using a function called `get_default_flags` to get the default flags. Its behavior is duplicated in both the default value of the `use_react_native!` function and in the body of the same function, making that helper actually redundant. In this change, we are deprecating it so we can remove it in 0.74 with no breakages. ## Changelog: [iOS][Deprecated] - Deprecate `get_default_flags` in Ruby scripts Reviewed By: dmytrorykun Differential Revision: D49147290 fbshipit-source-id: 41a9f9aa4ba5d1a31d86953fe78778b45d28d9b2 Original: facebook/react-native@f60b9f6
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#39389 The Podfile of the Template is using a function called `get_default_flags` to get the default flags. Its behavior is duplicated in both the default value of the `use_react_native!` function and in the body of the same function, making that helper actually redundant. In this change, we are deprecating it so we can remove it in 0.74 with no breakages. ## Changelog: [iOS][Deprecated] - Deprecate `get_default_flags` in Ruby scripts Reviewed By: dmytrorykun Differential Revision: D49147290 fbshipit-source-id: 41a9f9aa4ba5d1a31d86953fe78778b45d28d9b2 Original-Commit: facebook/react-native@f60b9f6
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#39389 The Podfile of the Template is using a function called `get_default_flags` to get the default flags. Its behavior is duplicated in both the default value of the `use_react_native!` function and in the body of the same function, making that helper actually redundant. In this change, we are deprecating it so we can remove it in 0.74 with no breakages. ## Changelog: [iOS][Deprecated] - Deprecate `get_default_flags` in Ruby scripts Reviewed By: dmytrorykun Differential Revision: D49147290 fbshipit-source-id: 41a9f9aa4ba5d1a31d86953fe78778b45d28d9b2 Original-Commit: facebook/react-native@f60b9f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The Podfile of the Template is using a function called
get_default_flagsto get the default flags.Its behavior is duplicated in both the default value of the
use_react_native!function and in the body of the same function, making that helper actually redundant.In this change, we are deprecating it so we can remove it in 0.74 with no breakages.
Changelog:
[iOS][Deprecated] - Deprecate
get_default_flagsin Ruby scriptsDifferential Revision: D49147290