Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ style enums 9/N: FlexDirection #39484

Closed
wants to merge 2 commits into from

Conversation

NickGerleman
Copy link
Contributor

Summary: Moves internal usages of YGDirection to Direction.

Differential Revision: D49336066

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 15, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336066

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 18, 2023
Summary:
X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Differential Revision: D49336066

fbshipit-source-id: c2184fa2d06a0ea36bdda4bcd0e901fe8a1a5563
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336066

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 18, 2023
Summary:
Pull Request resolved: facebook#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Differential Revision: D49336066

fbshipit-source-id: b599f6804ac3cdc34c9895854e0cec4e6909cd97
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336066

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 18, 2023
Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Differential Revision: D49336066

fbshipit-source-id: 304781aa4b923cf3baf2c1bf9ebe319f1df2ba37
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 18, 2023
Summary:
X-link: facebook/yoga#1394

Pull Request resolved: facebook#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Differential Revision: D49336066

fbshipit-source-id: ee12f0921e57731b8fb3665a9e665d2c95eb5e4b
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 18, 2023
Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Differential Revision: D49336066

fbshipit-source-id: 8ad34f3a30c9c68f4709996fae8e68eb83d8f4dd
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336066

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 18, 2023
Summary:
X-link: facebook/yoga#1394

Pull Request resolved: facebook#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Differential Revision: D49336066

fbshipit-source-id: c206910877777b76fb33d6346195d498281ac214
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 18, 2023
Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Differential Revision: D49336066

fbshipit-source-id: 7b68cc56610e0a8a9ffadcdfb67e9c7dec5c6ac4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336066

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 18, 2023
Summary:
X-link: facebook/yoga#1394

Pull Request resolved: facebook#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Differential Revision: D49336066

fbshipit-source-id: 0798a0b5a63c4e4c95d426b15f5be12ce69dfe1d
@analysis-bot
Copy link

analysis-bot commented Sep 18, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,333,853 +82
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,573,353 +87
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 95fb448
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336066

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 18, 2023
Summary:
X-link: facebook/yoga#1394

Pull Request resolved: facebook#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Differential Revision: D49336066

fbshipit-source-id: 80ceb171b88bf9fec1ac3c806ef9135a1d3c7a33
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 18, 2023
Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Differential Revision: D49336066

fbshipit-source-id: d7555c9621b073cf772155662f6a66519f1860df
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 18, 2023
Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Differential Revision: D49336066

fbshipit-source-id: fc9a360177466d74a7d1c6eee2b0277464660e1c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336066

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 18, 2023
Summary:
X-link: facebook/yoga#1394

Pull Request resolved: facebook#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Differential Revision: D49336066

fbshipit-source-id: 09b1165d8691becd14e196a259e87cb4736b4f19
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
Summary:
X-link: facebook/yoga#1394

Pull Request resolved: facebook#39484

Moves internal usages of YGDirection to Direction.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: 94a3b5c4982d02fb3dd78884fb2d0b648d39ea6d
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: 9da6e9152bb0417703e5e829499770e95e419895
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: 8c3d978cb1d9a3055b6009c25a3731eaa6275441
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336066

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
Summary:
X-link: facebook/yoga#1394

Pull Request resolved: facebook#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: b2c2577c072f5c1fac8a10f03739b4931836ae09
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: 64d82880ab5eccb42d46f72212f683378bcc8253
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: b5b500422221f4cdfcdc6b4d77504cb445a77cfd
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336066

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
Summary:
X-link: facebook/yoga#1394

Pull Request resolved: facebook#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: f2eb56bf65667a109ea2700d82ed187d533d8c9f
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: 1a657d4472ab17308f7148fa35569ddd53b4e5e7
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: ae685e88dda60f23aa23561e80b92593d5694102
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336066

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
Summary:
X-link: facebook/yoga#1394

Pull Request resolved: facebook#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: 46e2beee49428e9d8fdb1083b8cfc5708dc6762b
NickGerleman and others added 2 commits September 19, 2023 11:23
Summary: Moves internal usages of YGDirection to Direction.

Differential Revision: D49335231

fbshipit-source-id: 155fe938c7522c1f1596bc54fde91b5fe351798b
Summary:
X-link: facebook/yoga#1394

Pull Request resolved: facebook#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: 9a4e7df3a2db9ea35e3d17fbaf092a8880862dcb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336066

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
Pull Request resolved: facebook#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: 1af5da564cd771ae4ee636fc8fc9759a9c5908e1
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 93fcea7

facebook-github-bot pushed a commit to facebook/litho that referenced this pull request Sep 19, 2023
Summary:
X-link: facebook/yoga#1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: b49e1ffcd79a427e36ea8d2c26debaa98ef3e4c9
facebook-github-bot pushed a commit to facebook/yoga that referenced this pull request Sep 19, 2023
Summary:
Pull Request resolved: #1394

X-link: facebook/react-native#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: b49e1ffcd79a427e36ea8d2c26debaa98ef3e4c9
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b6dfec3.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 19, 2023
ShevO27 pushed a commit to ShevO27/react-native that referenced this pull request Sep 26, 2023
Summary:
X-link: facebook/yoga#1394

Pull Request resolved: facebook#39484

Moves internal usages of YGDirection to Direction.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49336066

fbshipit-source-id: b49e1ffcd79a427e36ea8d2c26debaa98ef3e4c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants