C++ style enums 14/N: Overflow #39537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49361843 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39537 Pull Request resolved: facebook#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: fc8f50aa0486738780f794a7380f75de42d4fbde
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39537 Pull Request resolved: facebook#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 966b690bd43c315f58e153c591e055780cb6bd66
|
This pull request was exported from Phabricator. Differential Revision: D49361843 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39537 X-link: facebook/yoga#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 6efcdf6085eaacf1495c7436e949595a3a92c6f6
NickGerleman
force-pushed
the
export-D49361843
branch
from
08d7a0a
to
665cbae
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39537 Pull Request resolved: facebook#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: ac5c9ed2cba945f11eac9107a48dbae21e08d1b7
|
This pull request was exported from Phabricator. Differential Revision: D49361843 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39537 X-link: facebook/yoga#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 7e887030f105121d8aecfeb47abbec676645d6f2
NickGerleman
force-pushed
the
export-D49361843
branch
from
665cbae
to
adcb6f4
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39537 Pull Request resolved: facebook#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: eec5fb5c1797ca9eecc6bc546a7ed8b1839595aa
|
This pull request was exported from Phabricator. Differential Revision: D49361843 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39537 X-link: facebook/yoga#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 1b61647540c077f005a6f1a4ae3bc6226db74ca2
NickGerleman
force-pushed
the
export-D49361843
branch
from
adcb6f4
to
2ff8f9a
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39537 Pull Request resolved: facebook#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 7da6a8647bb7f0820de469b94f748e832a7768f7
|
This pull request was exported from Phabricator. Differential Revision: D49361843 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39537 X-link: facebook/yoga#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: a14dde7ee0223dd7a6d6a1e5a554267098a4b603
NickGerleman
force-pushed
the
export-D49361843
branch
from
2ff8f9a
to
e863468
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39537 Pull Request resolved: facebook#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 4aaa87185c60e072b444f4dc4fb8180f7306a9c4
|
This pull request was exported from Phabricator. Differential Revision: D49361843 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39537 X-link: facebook/yoga#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 8479f71bf22b8c6e763779881924206a5e7aeb25
NickGerleman
force-pushed
the
export-D49361843
branch
from
e863468
to
2e584c2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49361843 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39537 X-link: facebook/yoga#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 7f2006732e752d70235ee747bfcd7437d64bacf7
NickGerleman
force-pushed
the
export-D49361843
branch
from
2e584c2
to
78dba87
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39537 Pull Request resolved: facebook#1398 Moves internal usages of YGOverflow to Overflow Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 6aa85a4eb8a4c44c91e44e78813ea28c54e90225
|
This pull request was exported from Phabricator. Differential Revision: D49361843 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39537 X-link: facebook/yoga#1398 Moves internal usages of YGOverflow to Overflow bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 7cd032b7f6208689cdc12b412f08b8175028caec
NickGerleman
force-pushed
the
export-D49361843
branch
from
a407108
to
efe1195
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39537 Pull Request resolved: facebook#1398 Moves internal usages of YGOverflow to Overflow bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 5a62eb6a1034a04b7e22487344e423e2ea6a6898
|
This pull request was exported from Phabricator. Differential Revision: D49361843 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39537 X-link: facebook/yoga#1398 Moves internal usages of YGOverflow to Overflow bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 8696442b1959355a2886987d46fc66806fcd5bd3
NickGerleman
force-pushed
the
export-D49361843
branch
from
efe1195
to
be34c80
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39537 Pull Request resolved: facebook#1398 Moves internal usages of YGOverflow to Overflow bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: f5d04e042a2c7a02ec63b0c96ee072b4c7786c2f
|
This pull request was exported from Phabricator. Differential Revision: D49361843 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39537 X-link: facebook/yoga#1398 Moves internal usages of YGOverflow to Overflow bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 40717ee0c341b56e58a4c7e9b43a79f811dab66b
NickGerleman
force-pushed
the
export-D49361843
branch
from
be34c80
to
7c6a99f
Compare
Summary: Moves internal usages of YGDirection to Direction. Differential Revision: D49335231 fbshipit-source-id: a681e429b174017c4ed7c54f426d56e48101520c
Summary: Moves internal usages of YGDirection to Direction. Differential Revision: https://www.internalfb.com/diff/D49336066?entry_point=27 fbshipit-source-id: 1d49c8059d5123996fabcd818c5814916c93d39c
Summary: Moves internal usages of YGJustify to Justify. Differential Revision: https://internalfb.com/D49336538 fbshipit-source-id: 6d663833180da372a89fde3da4fdcb62a859684a
Summary: Moves internal usages of YGAlign to Align Changelog: [Internal] Differential Revision: https://internalfb.com/D49337511 fbshipit-source-id: 4c084e8c1a554692ceaacfa4a9bb33fedbc1c56f
Summary: Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Differential Revision: D49361677 fbshipit-source-id: 0ed96f290da7a7d5bdfe44e8385595b7ed8e0101
Summary: Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Differential Revision: D49361746 fbshipit-source-id: 5d0277fb0cca3fb17133cf9ed5dbfd610559539b
Summary: Pull Request resolved: facebook#39537 X-link: facebook/yoga#1398 Moves internal usages of YGOverflow to Overflow bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 89615cb9ddc60fe88008d2af3b6de8298bb65f4f
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39537 Pull Request resolved: facebook#1398 Moves internal usages of YGOverflow to Overflow bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: c1ce4ab53a4202543f48b41a3da6200f3ea1a613
|
This pull request was exported from Phabricator. Differential Revision: D49361843 |
NickGerleman
force-pushed
the
export-D49361843
branch
from
7c6a99f
to
14ce1a4
Compare
Base commit: 95fb448 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39537 X-link: facebook/yoga#1398 Moves internal usages of YGOverflow to Overflow bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 42161aa8a26f64f052587b861120cdad0290ae46
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39537 Pull Request resolved: #1398 Moves internal usages of YGOverflow to Overflow bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 42161aa8a26f64f052587b861120cdad0290ae46
|
This pull request has been merged in e2e6895. |
ShevO27
pushed a commit
to ShevO27/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39537 X-link: facebook/yoga#1398 Moves internal usages of YGOverflow to Overflow bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361843 fbshipit-source-id: 42161aa8a26f64f052587b861120cdad0290ae46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/yoga#1398
Moves internal usages of YGOverflow to Overflow
Changelog: [Internal]
Reviewed By: rshest
Differential Revision: D49361843