Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update boost to 1.83.0 #39555

Closed
wants to merge 2 commits into from
Closed

Update boost to 1.83.0 #39555

wants to merge 2 commits into from

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Sep 20, 2023 •
edited
Loading

Summary:

Since folly is updated from 17154a6, it is good to bump boost too.

After updating boost, we can remove the Xcode 15 _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION workaround which originally to fix Xcode 15 for boost.

Changelog:

[GENERAL][CHANGED] - Update boost to 1.83.0

Test Plan:

  • CI passed
  • Build and launch RNTester on Android and iOS

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 20, 2023
cipolleschi
cipolleschi approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kudo for taking care of this! 🙌

@cipolleschi
Copy link
Contributor

This PR is based on #39552. Not sure how Meta internally deal with stacked PRs. This PR just adds a new commit based on #39552 anyway.

I think that this PR contains all the changes that are in #39552, so we can land this one only. Could you double-check that as well?

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Kudo
Copy link
Contributor Author

Kudo commented Sep 20, 2023

I think that this PR contains all the changes that are in #39552, so we can land this one only. Could you double-check that as well?

that's correct! good to know we can just land this one. let me update this pr's description/changelog and close #39552.

@Kudo Kudo changed the title Remove xcode 15 workaround for boost Update boost to 1.83.0 Sep 20, 2023
@Kudo Kudo mentioned this pull request Sep 20, 2023
Closed
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,333,695 -210
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,573,167 -174
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 7888338
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 20, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in b9f0bdd.

ShevO27 pushed a commit to ShevO27/react-native that referenced this pull request Sep 26, 2023
@Kudo @ShevO27
Remove xcode 15 workaround for boost (facebook#39555)
4fe01e6 
Summary:
Remove Xcode 15 `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` workaround for boost. If we update boost, we don't need the workaround anymore.
This PR is based on facebook#39552. Not sure how Meta internally deal with stacked PRs. This PR just adds a new commit based on facebook#39552 anyway.

## Changelog:

[IOS][CHANGED] - Remove Xcode 15 `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` workaround for boost

Pull Request resolved: facebook#39555

Test Plan: RNTester + Xcode 15

Reviewed By: cortinico

Differential Revision: D49454494

Pulled By: cipolleschi

fbshipit-source-id: aacabaa130b61598cf8bd206fdbb96d3b50ba74f
yayvery pushed a commit to discord/react-native that referenced this pull request Oct 9, 2023
@Kudo @yayvery
Remove xcode 15 workaround for boost (facebook#39555)
1b3367e 
Summary:
Remove Xcode 15 `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` workaround for boost. If we update boost, we don't need the workaround anymore.
This PR is based on facebook#39552. Not sure how Meta internally deal with stacked PRs. This PR just adds a new commit based on facebook#39552 anyway.

[IOS][CHANGED] - Remove Xcode 15 `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` workaround for boost

Pull Request resolved: facebook#39555

Test Plan: RNTester + Xcode 15

Reviewed By: cortinico

Differential Revision: D49454494

Pulled By: cipolleschi

fbshipit-source-id: aacabaa130b61598cf8bd206fdbb96d3b50ba74f
@liamjones
Copy link
Contributor

Something I've just noticed in relation to this PR when upgrading from 0.72.x to 0.73.x - if the _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION directive had been added to a project previously, it doesn't get removed again here.

Is that an issue or not? I noticed it's a CXX17 directive and 0.73 moves to c++20 so maybe it isn't obeyed anyway?

@cipolleschi
Copy link
Contributor

@liamjones it should not be an issue. The directive is needed to backport the name of an API that has changed. I don't think that it's an issue if we keep it. Unless you are seeing some specific errors: if that's the case, could you share them?

@liamjones
Copy link
Contributor

liamjones commented May 21, 2024 •
edited
Loading

@cipolleschi Nope, not seeing any errors. I just noticed it wasn't being removed when I did the RN upgrade and wanted to check if it was deliberate. Thanks for confirming it was! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kudo @cipolleschi @facebook-github-bot @analysis-bot @liamjones