Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate building Spannable #39621

Closed
wants to merge 6 commits into from
Closed

De-duplicate building Spannable #39621

wants to merge 6 commits into from

Conversation

cubuspl42
Copy link
Contributor

@cubuspl42 cubuspl42 commented Sep 23, 2023 •
edited
Loading

I'd like to suggest some non-trivial changes to this area in the context of implementing this functionality, and that seems impossible with the current level of code duplication.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 23, 2023
@cubuspl42 cubuspl42 changed the title deduplicate build spannable De-duplicate building Spannable Sep 23, 2023
@analysis-bot
Copy link

analysis-bot commented Sep 23, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,337,423 +1,179
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,576,522 +2,307
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 030663b
Branch: main

@github-actions
Copy link

github-actions bot commented Sep 23, 2023 •
edited
Loading

Fails
🚫

📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format
Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against fa79677

@cubuspl42 cubuspl42 force-pushed the deduplicate-build-spannable branch from 4348cab to f915d3d Compare September 25, 2023 11:27
@cubuspl42
De-duplicate building Spannable from fragments
5b263d4 
...between the variant which deserializes fragments from a `MapBuffer`
and a variant which depends `on com.facebook.react.bridge.*` APIs
@cubuspl42
De-duplicate building Spannable
2ed4760 
...between the variant that builds it from fragments and the on which
builds it from the shadow tree
@cubuspl42
Introduce an abstraction for getting the effective font size
828b747 
...which further de-duplicates the `Spannable`-building code
@cubuspl42
Make the text span order consistent between Paper and Fabric
e28f3f2 
...hoping that the different order wasn't intentional
@cubuspl42
Move all text attribute spans adds to a single shared method
05b5fd5 
...which is now possible, because they have the same order
@cubuspl42
Extract some helper methods in ReactBaseTextShadowNode
fa79677 
...for consistency with the de-duplicated code
@cubuspl42 cubuspl42 force-pushed the deduplicate-build-spannable branch from f915d3d to fa79677 Compare September 25, 2023 11:28
@cubuspl42
Copy link
Contributor Author

Uh, I didn't use the template and changed the conception of the PR organization, I'll open a new one

@cubuspl42 cubuspl42 closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cubuspl42 @analysis-bot @facebook-github-bot