Reduce visibility of PerformanceCounter #39746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49803283 |
Base commit: 294c0fa |
|
This pull request was exported from Phabricator. Differential Revision: D49803283 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39746 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of PerformanceCounter Reviewed By: arushikesarwani94 Differential Revision: D49803283 fbshipit-source-id: 39aff598ddfd56a3fde75499099a5f58ce6ae496
mdvacca
force-pushed
the
export-D49803283
branch
from
eb02e62 to
3bbb5c5
Compare
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromArray Differential Revision: D49752134 fbshipit-source-id: 0766ade364e3cdfe9997a5947e3cea7a17dc1c0b
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromMap Differential Revision: D49752137 fbshipit-source-id: 663b8b951780896a01ec737753ef684264082b0c
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSCJavaScriptExecutorFactory Differential Revision: D49752141 fbshipit-source-id: 4f2cc3e96116e9544851564a687d0f0e1b8fbe76
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSIModuleHolder Differential Revision: D49752136 fbshipit-source-id: 4cdf407833a354c06d92b95a4ec84b5e33eb2b87
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSIModuleRegistry. Differential Revision: D49752138 fbshipit-source-id: ca2b4fe7ad0a1027c86592676d3d76f6ec933e29
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSInstance Differential Revision: D49752139 fbshipit-source-id: 47e038562349b2596a30209381f21d584bed18a0
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of NativeArgumentsParseException Differential Revision: D49752145 fbshipit-source-id: 708ea1fbcb48f646fd03edd51a0ad04a2bf7f82f
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of NativeArrayInterface Differential Revision: D49803296 fbshipit-source-id: 2715ae89f7019f9c0666a7203143f3273039cad5
|
This pull request was exported from Phabricator. Differential Revision: D49803283 |
Summary: Pull Request resolved: facebook#39746 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of PerformanceCounter Reviewed By: arushikesarwani94 Differential Revision: D49803283 fbshipit-source-id: 69f0d4049e8180286963de73c9c891453c81c40b
mdvacca
force-pushed
the
export-D49803283
branch
from
3bbb5c5 to
02775de
Compare
|
This pull request has been merged in 614afb5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of PerformanceCounter
Reviewed By: arushikesarwani94
Differential Revision: D49803283