Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging of error in MainReactPackage.getReactModuleInfoProvider() #41088

Closed
wants to merge 3 commits into from
Closed

Fix logging of error in MainReactPackage.getReactModuleInfoProvider() #41088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
812d29d
Reduce visibility of DebugCorePackage (#41014)
mdvacca Oct 19, 2023
357b429
Deprecate CompositeReactPackageTurboModuleManagerDelegate
mdvacca Oct 19, 2023
0c39d41
Fix logging of error in MainReactPackage.getReactModuleInfoProvider()
mdvacca Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...oid/src/main/java/com/facebook/react/CompositeReactPackageTurboModuleManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
import java.util.Collections;
import java.util.List;

@Deprecated(
since =
"CompositeReactPackageTurboModuleManagerDelegate is deprecated and will be deleted in the future. Please use ReactPackage interface or BaseReactPackage instead.")
@DoNotStrip
public class CompositeReactPackageTurboModuleManagerDelegate
extends ReactPackageTurboModuleManagerDelegate {
Expand Down
3 changes: 2 additions & 1 deletion packages/react-native/ReactAndroid/src/main/java/com/facebook/react/DebugCorePackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@
nativeModules = {
JSCHeapCapture.class,
})
public class DebugCorePackage extends TurboReactPackage implements ViewManagerOnDemandReactPackage {
/* package */
class DebugCorePackage extends TurboReactPackage implements ViewManagerOnDemandReactPackage {
private @Nullable Map<String, ModuleSpec> mViewManagers;

public DebugCorePackage() {}
Expand Down
6 changes: 4 additions & 2 deletions ...es/react-native/ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,10 +303,12 @@ public ReactModuleInfoProvider getReactModuleInfoProvider() {
return () -> reactModuleInfoMap;
} catch (InstantiationException e) {
throw new RuntimeException(
"No ReactModuleInfoProvider for CoreModulesPackage$$ReactModuleInfoProvider", e);
"No ReactModuleInfoProvider for com.facebook.react.shell.MainReactPackage$$ReactModuleInfoProvider",
e);
} catch (IllegalAccessException e) {
throw new RuntimeException(
"No ReactModuleInfoProvider for CoreModulesPackage$$ReactModuleInfoProvider", e);
"No ReactModuleInfoProvider for com.facebook.react.shell.MainReactPackage$$ReactModuleInfoProvider",
e);
}
}
}