feat: selectionHandleColor prop on Android #41092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
jakex7
force-pushed
the
feature/selectionHandleColor
branch
from
1521e8b to
eb5647b
Compare
jakex7
force-pushed
the
feature/selectionHandleColor
branch
from
eb5647b to
c411416
Compare
Base commit: c267a06 |
|
Thanks for contributing! Having props that overlap require careful handling. If in a state update you change just Can you validate that when you change these properties in different order (eg add useState hook to control each individually) that this still works correctly? |
|
Hi @javache, During the testing, I also found incorrect behavior when changing from color to selectionHandleColor-order-test.mov |
javache
reviewed
Nov 10, 2023
packages/react-native/Libraries/Components/TextInput/TextInput.js
Outdated
Show resolved
Hide resolved
… they're not both in otherProps and colorProps.
javache
approved these changes
Nov 13, 2023
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: This PR addresses the problem raised in the facebook#41004 issue. The current logic is that `selectionColor` on iOS sets the color of the selection, handles, and cursor. On Android it looks similar, while it doesn't change the color of the handles if the API level is higher than 27. In addition, on Android there was an option to set the color of the cursor by `cursorColor` prop, but it didn't work if the `selectionCursor` was set. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [ADDED] - Make same behavior of the `selectionColor` prop on Android as iOS [ANDROID] [ADDED] - Introduced `selectionHandleColor` as a separate prop [ANDROID] [CHANGED] - Allowing `cursorColor` and `selectionHandleColor` to override `selectionColor` on Android Pull Request resolved: facebook#41092 Test Plan: Manual tests in rn-tester: ### `selectionColor` same as iOS, sets selection, handles and cursor color _There is a way to set only "rectangle" color by setting other props as null_  ### `selectionHandleColor`  ### `cursorColor`  Reviewed By: NickGerleman Differential Revision: D51253298 Pulled By: javache fbshipit-source-id: 290284aa38c6ba0aa6998b937258788ce6376431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses the problem raised in the #41004 issue.
The current logic is that
selectionColoron iOS sets the color of the selection, handles, and cursor. On Android it looks similar, while it doesn't change the color of the handles if the API level is higher than 27. In addition, on Android there was an option to set the color of the cursor bycursorColorprop, but it didn't work if theselectionCursorwas set.Changelog:
[GENERAL] [ADDED] - Make same behavior of the
selectionColorprop on Android as iOS[ANDROID] [ADDED] - Introduced
selectionHandleColoras a separate prop[ANDROID] [CHANGED] - Allowing
cursorColorandselectionHandleColorto overrideselectionColoron AndroidTest Plan:
Manual tests in rn-tester:
selectionColorsame as iOS, sets selection, handles and cursor colorThere is a way to set only "rectangle" color by setting other props as null
selectionHandleColorcursorColor