remove warning to tell user to set requiresMainQueueSetup #41294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50919152 |
Summary: Changelog: [Internal] modules will be setup on main queue for any the following criteria: - override requiresMainQueueSetup and set it to yes - have a method that starts with `init` - have `constantsToExport` implemented these methods return `NO` but don't fulfill the latter criteria, so we should just delete them Reviewed By: cipolleschi Differential Revision: D50919151
…1294) Summary: Changelog: [Internal] i believe this warning is outdated, i don't think having a custom initializer or exporting constants means that your module needs to be setup on main. Reviewed By: cipolleschi Differential Revision: D50919152
philIip
force-pushed
the
export-D50919152
branch
from
6c7d85d
to
524b5a3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50919152 |
Base commit: 22c4099 |
|
This pull request has been merged in fcda37f. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…1294) Summary: Pull Request resolved: facebook#41294 Changelog: [Internal] i believe this warning is outdated, i don't think having a custom initializer or exporting constants means that your module needs to be setup on main. Reviewed By: cipolleschi Differential Revision: D50919152 fbshipit-source-id: dc91af5fc88eca4f07a5f35adb888160b978cc38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
i believe this warning is outdated, i don't think having a custom initializer or exporting constants means that your module needs to be setup on main.
Reviewed By: cipolleschi
Differential Revision: D50919152