Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: TraceUpdates native component -> DebuggingOverlay #41562

Closed
wants to merge 2 commits into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Nov 20, 2023

Summary:
Changelog: [Internal]

We will use this native component as a single layer for drawing debugging information: both for trace updates and inspected components from React DevTools.

Differential Revision: D51470789

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Nov 20, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51470789

hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Nov 21, 2023
…#41562)

Summary:

Changelog: [Internal]

We will use this native component as a single layer for drawing debugging information: both for trace updates and inspected components from React DevTools.

Differential Revision: D51470789
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51470789

@analysis-bot
Copy link

analysis-bot commented Nov 21, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,666,497 -7
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,049,721 +0
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8a62d61
Branch: main

hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Nov 21, 2023
…#41562)

Summary:

Changelog: [Internal]

We will use this native component as a single layer for drawing debugging information: both for trace updates and inspected components from React DevTools.

Differential Revision: D51470789
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51470789

hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Nov 22, 2023
…#41562)

Summary:

Changelog: [Internal]

We will use this native component as a single layer for drawing debugging information: both for trace updates and inspected components from React DevTools.

Differential Revision: D51470789
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Nov 22, 2023
…#41562)

Summary:

Changelog: [Internal]

We will use this native component as a single layer for drawing debugging information: both for trace updates and inspected components from React DevTools.

Differential Revision: D51470789
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51470789

hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Nov 23, 2023
…#41562)

Summary:

Changelog: [Internal]

We will use this native component as a single layer for drawing debugging information: both for trace updates and inspected components from React DevTools.

Reviewed By: javache

Differential Revision: D51470789
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51470789

hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Nov 23, 2023
…#41562)

Summary:

Changelog: [Internal]

We will use this native component as a single layer for drawing debugging information: both for trace updates and inspected components from React DevTools.

Reviewed By: javache

Differential Revision: D51470789
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51470789

hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Nov 23, 2023
…#41562)

Summary:

Changelog: [Internal]

We will use this native component as a single layer for drawing debugging information: both for trace updates and inspected components from React DevTools.

Reviewed By: javache

Differential Revision: D51470789
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51470789

Ruslan Lesiutin added 2 commits November 23, 2023 06:36
Summary:

Changelog:
[iOS][Added] - support "highlighting updates when components render" feature from React DevTools

Reviewed By: javache

Differential Revision: D51470012
…#41562)

Summary:

Changelog: [Internal]

We will use this native component as a single layer for drawing debugging information: both for trace updates and inspected components from React DevTools.

Reviewed By: javache

Differential Revision: D51470789
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51470789

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 23, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ed1056e.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
…#41562)

Summary:
Pull Request resolved: facebook#41562

Changelog: [Internal]

We will use this native component as a single layer for drawing debugging information: both for trace updates and inspected components from React DevTools.

Reviewed By: javache

Differential Revision: D51470789

fbshipit-source-id: 6c4633d2b70c2c2635a2bbfcd7adf1c727b73585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants