Remove unused flag in Old Architecture codegen #41579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51493765 |
Base commit: 2a4338d |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 21, 2023
Summary: This change remove a flag that is unused. ## Changelog [Internal] - Remove unused Flag Reviewed By: dmytrorykun Differential Revision: D51493765
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 21, 2023
Summary: This change remove a flag that is unused. ## Changelog [Internal] - Remove unused Flag Reviewed By: dmytrorykun Differential Revision: D51493765
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 22, 2023
Summary: This change remove a flag that is unused. ## Changelog [Internal] - Remove unused Flag Reviewed By: dmytrorykun Differential Revision: D51493765
cipolleschi
force-pushed
the
export-D51493765
branch
from
4698657 to
9554da4
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 22, 2023
Summary: This change remove a flag that is unused. ## Changelog [Internal] - Remove unused Flag Reviewed By: dmytrorykun Differential Revision: D51493765
|
This pull request was exported from Phabricator. Differential Revision: D51493765 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 22, 2023
Summary: This change remove a flag that is unused. ## Changelog [Internal] - Remove unused Flag Reviewed By: dmytrorykun Differential Revision: D51493765
cipolleschi
force-pushed
the
export-D51493765
branch
from
9554da4 to
ca544f7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51493765 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 22, 2023
Summary: This change remove a flag that is unused. ## Changelog [Internal] - Remove unused Flag Reviewed By: dmytrorykun Differential Revision: D51493765
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 22, 2023
Summary: This change remove a flag that is unused. ## Changelog [Internal] - Remove unused Flag Reviewed By: dmytrorykun Differential Revision: D51493765
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 22, 2023
Summary: This change remove a flag that is unused. ## Changelog [Internal] - Remove unused Flag Reviewed By: dmytrorykun Differential Revision: D51493765
cipolleschi
force-pushed
the
export-D51493765
branch
from
ca544f7 to
efe4cb2
Compare
added 2 commits
November 22, 2023 02:48
Summary: The RN_FABRIC_ENABLED has been deprecated and superseded by the RCT_NEW_ARCH_ENABLED for a while now. This change removes it, from the codebase as now we always have the Fabric pod available to the codebase. ## Changelog [Internal] - Remove RN_FABRIC_ENABLED flag Reviewed By: dmytrorykun Differential Revision: D51468332
Summary: This change remove a flag that is unused. ## Changelog [Internal] - Remove unused Flag Reviewed By: dmytrorykun Differential Revision: D51493765
|
This pull request was exported from Phabricator. Differential Revision: D51493765 |
cipolleschi
force-pushed
the
export-D51493765
branch
from
efe4cb2 to
8a049f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51493765 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 22, 2023
Summary: This change remove a flag that is unused. ## Changelog [Internal] - Remove unused Flag Reviewed By: dmytrorykun Differential Revision: D51493765
|
This pull request has been merged in a607692. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41579 This change remove a flag that is unused. ## Changelog [Internal] - Remove unused Flag Reviewed By: dmytrorykun Differential Revision: D51493765 fbshipit-source-id: f8cbce991d80d4f51363cdd4f379e6b214b2b2df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change remove a flag that is unused.
Changelog
[Internal] - Remove unused Flag
Differential Revision: D51493765