Small refactor of image attached callbacks logic #41701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51660288 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 29, 2023
Summary: I did a hotfix for this logic in D51618512. This does a small refactor to improve the code (moving more shared code to the hook and avoiding creating a closure unnecessarily in every call to it). Changelog: [internal] Reviewed By: javache Differential Revision: D51660288
rubennorte
force-pushed
the
export-D51660288
branch
from
a04bc20 to
a084e09
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51660288 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 29, 2023
Summary: I did a hotfix for this logic in D51618512. This does a small refactor to improve the code (moving more shared code to the hook and avoiding creating a closure unnecessarily in every call to it). Changelog: [internal] Reviewed By: javache Differential Revision: D51660288
rubennorte
force-pushed
the
export-D51660288
branch
from
a084e09 to
8b9dafa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51660288 |
rubennorte
force-pushed
the
export-D51660288
branch
from
8b9dafa to
5ff4251
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51660288 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 29, 2023
Summary: I did a hotfix for this logic in D51618512. This does a small refactor to improve the code (moving more shared code to the hook and avoiding creating a closure unnecessarily in every call to it). Changelog: [internal] Reviewed By: javache Differential Revision: D51660288
rubennorte
force-pushed
the
export-D51660288
branch
from
5ff4251 to
16f27f2
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 29, 2023
Summary: I did a hotfix for this logic in D51618512. This does a small refactor to improve the code (moving more shared code to the hook and avoiding creating a closure unnecessarily in every call to it). Changelog: [internal] Reviewed By: javache Differential Revision: D51660288
|
This pull request was exported from Phabricator. Differential Revision: D51660288 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 29, 2023
Summary: I did a hotfix for this logic in D51618512. This does a small refactor to improve the code (moving more shared code to the hook and avoiding creating a closure unnecessarily in every call to it). Changelog: [internal] Reviewed By: javache Differential Revision: D51660288
rubennorte
force-pushed
the
export-D51660288
branch
from
16f27f2 to
3492bf0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51660288 |
Summary: I did a hotfix for this logic in D51618512. This does a small refactor to improve the code (moving more shared code to the hook and avoiding creating a closure unnecessarily in every call to it). Changelog: [internal] Reviewed By: javache Differential Revision: D51660288
rubennorte
force-pushed
the
export-D51660288
branch
from
3492bf0 to
c9420e9
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 29, 2023
Summary: I did a hotfix for this logic in D51618512. This does a small refactor to improve the code (moving more shared code to the hook and avoiding creating a closure unnecessarily in every call to it). Changelog: [internal] Reviewed By: javache Differential Revision: D51660288
|
This pull request was exported from Phabricator. Differential Revision: D51660288 |
|
This pull request has been merged in c120ccb. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41701 I did a hotfix for this logic in D51618512. This does a small refactor to improve the code (moving more shared code to the hook and avoiding creating a closure unnecessarily in every call to it). Changelog: [internal] Reviewed By: javache Differential Revision: D51660288 fbshipit-source-id: 472836840b19958402bd0de3e2c09c7cec004156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I did a hotfix for this logic in D51618512. This does a small refactor to improve the code (moving more shared code to the hook and avoiding creating a closure unnecessarily in every call to it).
Changelog: [internal]
Reviewed By: javache
Differential Revision: D51660288