Clarify threading of OnViewAttach mount items #41704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51662154 |
Base commit: 05ed007 |
|
This pull request was exported from Phabricator. Differential Revision: D51662154 |
javache
force-pushed
the
export-D51662154
branch
from
6b47bbe to
322d9e1
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 30, 2023
Summary: `mOnViewAttachItems` was set to be be concurrent, but this would be unexpected, as all mount item operations occur solely on the main thread. Simplify this to be just a LinkedList and annotate the methods as being UI thread only. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D51662154
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 30, 2023
Summary: `mOnViewAttachItems` was set to be be concurrent, but this would be unexpected, as all mount item operations occur solely on the main thread. Simplify this to be just a LinkedList and annotate the methods as being UI thread only. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D51662154
javache
force-pushed
the
export-D51662154
branch
from
322d9e1 to
ad295cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51662154 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 30, 2023
Summary: `mOnViewAttachItems` was set to be be concurrent, but this would be unexpected, as all mount item operations occur solely on the main thread. Simplify this to be just a LinkedList and annotate the methods as being UI thread only. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D51662154
javache
force-pushed
the
export-D51662154
branch
from
ad295cd to
f5c90b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51662154 |
Summary: `mOnViewAttachItems` was set to be be concurrent, but this would be unexpected, as all mount item operations occur solely on the main thread. Simplify this to be just a LinkedList and annotate the methods as being UI thread only. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D51662154
javache
force-pushed
the
export-D51662154
branch
from
f5c90b9 to
a6f34d0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51662154 |
|
This pull request has been merged in 424ac63. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41704 `mOnViewAttachItems` was set to be be concurrent, but this would be unexpected, as all mount item operations occur solely on the main thread. Simplify this to be just a LinkedList and annotate the methods as being UI thread only. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D51662154 fbshipit-source-id: 9fe5784bce8a38d1339b5e3675791414676b6f4d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
mOnViewAttachItemswas set to be be concurrent, but this would be unexpected, as all mount item operations occur solely on the main thread.Simplify this to be just a LinkedList and annotate the methods as being UI thread only.
Changelog: [Internal]
Differential Revision: D51662154