Change strict layout conformance to not use the new static changes #41733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51731778 |
Base commit: c30f2b6 |
…acebook#41733) Summary: I am currently implementing position: static in Yoga. I have a huge stack of changes that is ready to ship but we are waiting on the default position type to be relative before shipping. The reason being, my changes will affect a whole ton of styles where there is no position set so if we can make static no longer the default we can safely ship this new code. However, this will take a while and keeping up with this stack of diffs though merge conflicts, flakey tests, and general slowness for my IDE is getting annoying. So a solution here is to ship that stack and make it so that no one gets this functionality by changing the strict layout conformance to include the errata that is gating my changes. The end result being that the code can be shipped but will have no affect at the time being. Right now, because that code is in a different branch and not on prod, this change will do nothing. Changelog: [Internal] Reviewed By: javache Differential Revision: D51731778
joevilches
force-pushed
the
export-D51731778
branch
from
2f17e0f to
fbb341c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51731778 |
|
This pull request has been merged in 01c627e. |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 26, 2023
Summary: Static is no longer the default with the previous diff. We can undo this change. See D51731778 (facebook#41733) for context Changelog: [Internal] Differential Revision: D52381124
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 26, 2023
Summary: Static is no longer the default with the previous diff. We can undo this change. See D51731778 (facebook#41733) for context Changelog: [Internal] Differential Revision: D52381124
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 26, 2023
Summary: Static is no longer the default with the previous diff. We can undo this change. See D51731778 (facebook#41733) for context Changelog: [Internal] Differential Revision: D52381124
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 28, 2023
Summary: Static is no longer the default with the previous diff. We can undo this change. See D51731778 (facebook#41733) for context Changelog: [Internal] Differential Revision: D52381124
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 3, 2024
Summary: Static is no longer the default with the previous diff. We can undo this change. See D51731778 (facebook#41733) for context Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52381124
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 3, 2024
Summary: Static is no longer the default with the previous diff. We can undo this change. See D51731778 (facebook#41733) for context Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52381124
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 3, 2024
Summary: Static is no longer the default with the previous diff. We can undo this change. See D51731778 (facebook#41733) for context Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52381124
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 3, 2024
Summary: Static is no longer the default with the previous diff. We can undo this change. See D51731778 (facebook#41733) for context Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52381124
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 3, 2024
Summary: Static is no longer the default with the previous diff. We can undo this change. See D51731778 (facebook#41733) for context Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52381124
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 3, 2024
Summary: Static is no longer the default with the previous diff. We can undo this change. See D51731778 (facebook#41733) for context Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52381124
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41733) Summary: Pull Request resolved: facebook#41733 I am currently implementing position: static in Yoga. I have a huge stack of changes that is ready to ship but we are waiting on the default position type to be relative before shipping. The reason being, my changes will affect a whole ton of styles where there is no position set so if we can make static no longer the default we can safely ship this new code. However, this will take a while and keeping up with this stack of diffs though merge conflicts, flakey tests, and general slowness for my IDE is getting annoying. So a solution here is to ship that stack and make it so that no one gets this functionality by changing the strict layout conformance to include the errata that is gating my changes. The end result being that the code can be shipped but will have no affect at the time being. Right now, because that code is in a different branch and not on prod, this change will do nothing. Changelog: [Internal] Reviewed By: javache Differential Revision: D51731778 fbshipit-source-id: f0b7fd8559adb19e1658b3ac64fcfc4c5f8ecdf7
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#42063 Static is no longer the default with the previous diff. We can undo this change. See D51731778 (facebook#41733) for context Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52381124 fbshipit-source-id: 1e4336be6db5aa5d8786fb4f0a211558a7f66365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I am currently implementing position: static in Yoga. I have a huge stack of changes that is ready to ship but we are waiting on the default position type to be relative before shipping. The reason being, my changes will affect a whole ton of styles where there is no position set so if we can make static no longer the default we can safely ship this new code. However, this will take a while and keeping up with this stack of diffs though merge conflicts, flakey tests, and general slowness for my IDE is getting annoying. So a solution here is to ship that stack and make it so that no one gets this functionality by changing the strict layout conformance to include the errata that is gating my changes. The end result being that the code can be shipped but will have no affect at the time being.
Right now, because that code is in a different branch and not on prod, this change will do nothing.
Changelog: [Internal]
Differential Revision: D51731778