Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve e2e local testing script #41751

Closed
wants to merge 1 commit into from
Closed

feat: improve e2e local testing script #41751

wants to merge 1 commit into from

Conversation

Titozzz
Copy link
Collaborator

@Titozzz Titozzz commented Dec 1, 2023

Summary:

iOS?ios?android?Android?
Always making typos when using the local testing script with the platform argument... No more!

Changelog:

[INTERNAL][ADDED] - Improved E2E local testing script to be more flexible

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
⚠️

scripts/test-e2e-local.js#L19 - scripts/test-e2e-local.js line 19 – Requires should be sorted alphabetically (lint/sort-imports)

Generated by 🚫 dangerJS against 9863a57

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 1, 2023
@facebook-github-bot
Copy link
Contributor

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,705,457 -4
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,096,710 -2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: a3f238a
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 1, 2023
@facebook-github-bot
Copy link
Contributor

@huntie merged this pull request in 84b0027.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
@Titozzz @Othinn
feat: improve e2e local testing script (facebook#41751)
134c7e2 
Summary:
iOS?ios?android?Android?
Always making typos when using the local testing script with the platform argument... No more!

## Changelog:

[INTERNAL][ADDED] - Improved E2E local testing script to be more flexible

Pull Request resolved: facebook#41751

Reviewed By: cortinico

Differential Revision: D51758529

Pulled By: huntie

fbshipit-source-id: d9e633567a59fcfac1057cf1f21714ccef27ebb2
@cortinico cortinico deleted the titozzz/improve-e2e-local-script branch June 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huntie huntie huntie approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Titozzz @facebook-github-bot @analysis-bot @huntie