Add GraphNode example for Cxx TMs #41766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51783974 |
Base commit: 3854735 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 2, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 2, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 2, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
force-pushed
the
export-D51783974
branch
from
f0716e6 to
ad82565
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51783974 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 3, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
force-pushed
the
export-D51783974
branch
from
ad82565 to
d84338c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51783974 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 3, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
force-pushed
the
export-D51783974
branch
from
d84338c to
2aaf695
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51783974 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 3, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 3, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 3, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 3, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 3, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
force-pushed
the
export-D51783974
branch
from
2aaf695 to
6d67090
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51783974 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
force-pushed
the
export-D51783974
branch
from
6d67090 to
4dcd7d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51783974 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Differential Revision: D51783974
Summary: Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Reviewed By: rshest Differential Revision: D51783974
christophpurrer
force-pushed
the
export-D51783974
branch
from
4dcd7d1 to
e2901fd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51783974 |
|
This pull request was successfully merged by @christophpurrer in 5754b4a. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in 5754b4a. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41766 Changelog: [Internal] Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM. Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common. Reviewed By: rshest Differential Revision: D51783974 fbshipit-source-id: 7352db1a354cd7da32febc650f7cc5e10dd16d2d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Adds a simple example showing a recursive node inside a collection in a Cxx TM.
Currently we can't auto-generate the necessary C++ Types - but we can add it later if this scenarios becomes really common.
Differential Revision: D51783974