Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flow exact object syntax {| brace pipe |} from TM example #41779

Closed

Conversation

christophpurrer
Copy link
Contributor

Summary:
Changelog: [Internal]

exact_by_default (https://flow.org/en/docs/types/objects/#exact-and-inexact-object-types) is turned on - https://github.com/facebook/react-native/blob/main/.flowconfig#L40 - so we don't need these extra |.

Differential Revision: D51803601

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51803601

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Dec 4, 2023
@analysis-bot
Copy link

analysis-bot commented Dec 4, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,726,031 +10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,113,189 +3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: ead73de
Branch: main

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Dec 4, 2023
…ebook#41779)

Summary:

Changelog: [Internal]

`exact_by_default` (https://flow.org/en/docs/types/objects/#exact-and-inexact-object-types) is turned on - https://github.com/facebook/react-native/blob/main/.flowconfig#L40 - so we don't need these extra `|`.

Reviewed By: rshest

Differential Revision: D51803601
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51803601

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Dec 4, 2023
…ebook#41779)

Summary:

Changelog: [Internal]

`exact_by_default` (https://flow.org/en/docs/types/objects/#exact-and-inexact-object-types) is turned on - https://github.com/facebook/react-native/blob/main/.flowconfig#L40 - so we don't need these extra `|`.

Reviewed By: rshest

Differential Revision: D51803601
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51803601

…ebook#41779)

Summary:

Changelog: [Internal]

`exact_by_default` (https://flow.org/en/docs/types/objects/#exact-and-inexact-object-types) is turned on - https://github.com/facebook/react-native/blob/main/.flowconfig#L40 - so we don't need these extra `|`.

Reviewed By: rshest

Differential Revision: D51803601
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51803601

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Dec 4, 2023
…ebook#41779)

Summary:

Changelog: [Internal]

`exact_by_default` (https://flow.org/en/docs/types/objects/#exact-and-inexact-object-types) is turned on - https://github.com/facebook/react-native/blob/main/.flowconfig#L40 - so we don't need these extra `|`.

Reviewed By: rshest

Differential Revision: D51803601
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a481ae7.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 4, 2023
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
…ebook#41779)

Summary:
Pull Request resolved: facebook#41779

Changelog: [Internal]

`exact_by_default` (https://flow.org/en/docs/types/objects/#exact-and-inexact-object-types) is turned on - https://github.com/facebook/react-native/blob/main/.flowconfig#L40 - so we don't need these extra `|`.

Reviewed By: rshest

Differential Revision: D51803601

fbshipit-source-id: bef3699333471948330c4ae541e7a7023a7b1485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants