Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CocoaPods crash with nonexistent files #41848

Conversation

tyronet-sportsbet
Copy link

Summary:

Xcode Projects can contain files that don't exist until build time. If one of these happens to end with Info.plist (as is this case with our project), CocoaPods will crash, since utils.rb tries to patch all of these with ATS stuff. In the case where these files don't exist on disk, this CocoaPods post-install job should simply ignore those file references.

Changelog:

[IOS] [FIXED] - Fixed CocoaPods crashing when Xcode project contains non-existent -Info.plist file

Test Plan:

I've refactored the apply_ats_config method to also accept a file_manager param so that the file manager can be mocked in the unit tests. I have confirmed that the unit tests continue to pass, and also when I have applied the changes to utils.rb in react native in our main project's node_modules, a pod install now no longer crashes.

@facebook-github-bot
Copy link
Contributor

Hi @tyronet-sportsbet!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@tyronet-sportsbet
Copy link
Author

Apologies for letting this die on the vine; we're still trying to get the CLA signed at the corporate level and this takes time. In the meantime, I've noticed this patch is now no longer necessary due to #42637, so I'm closing this PR for now. If that ATS config patch system ever makes its way back in though it's worth keeping in mind this particular use case. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants