Remove unused bundle status reporting from inspector infra #41975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Original commit changeset: 29e1aba9c4ea Original Phabricator Diff: D49956535 D49956535 added the new behaviour of logging helpful messages to the CDP console when the app is backgrounded/foregrounded. The underlying UX issue is legitimate: how do we reinforce the mental connection between the debugger frontend and the app being debugged, when they might be running in different windows or even machines, and particularly when the app might be backgrounded while the debugger frontend remains active. However, this implementation is too closely coupled to the socket management layer, and is iOS-specific to boot. I'm removing it here to simplify porting `RCTInspectorPackagerConnection` to C++. We can revisit this UX problem later - preferably by investigating how it's handled in the case of Chrome Android and a remote DevTools client. This feature has not been included in an OSS release of React Native yet, so very few users will be affected by its removal. Changelog: [iOS][Removed] - Revert D49956535; remove console.log notification in DevTools if app transitions between back/foreground. Reviewed By: blakef Differential Revision: D51468311
Summary: Changelog: [Internal] Switches `RCTInspectorPackagerConnection` to use the recommended and type-safe `didReceiveMessageWithString` method to receive messages from SRWebSocket. Differential Revision: D52257082
Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [Internal] Differential Revision: D52258567
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52258567 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Dec 18, 2023
…41975) Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [Internal] Differential Revision: D52258567
Base commit: 27f38f6 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Dec 18, 2023
…41975) Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [Internal] Differential Revision: D52258567
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Dec 19, 2023
…41975) Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [Internal] Reviewed By: huntie Differential Revision: D52258567
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Dec 19, 2023
…41975) Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [Breaking][General] Remove APIs for reporting bundle download status to inspector-proxy Reviewed By: huntie Differential Revision: D52258567
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Dec 19, 2023
…41975) Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [General][Breaking] Remove APIs for reporting bundle download status to inspector-proxy, which does not use this information. Reviewed By: huntie Differential Revision: D52258567
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Dec 20, 2023
…41975) Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [General][Breaking] Remove APIs for reporting bundle download status to inspector-proxy, which does not use this information. Reviewed By: huntie Differential Revision: D52258567
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Dec 20, 2023
…41975) Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [General][Breaking] Remove APIs for reporting bundle download status to inspector-proxy, which does not use this information. Reviewed By: huntie Differential Revision: D52258567
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Dec 20, 2023
…41975) Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [General][Breaking] Remove APIs for reporting bundle download status to inspector-proxy, which does not use this information. Reviewed By: huntie Differential Revision: D52258567
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Dec 20, 2023
…41975) Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [General][Breaking] Remove APIs for reporting bundle download status to inspector-proxy, which does not use this information. Reviewed By: huntie Differential Revision: D52258567
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Dec 20, 2023
…41975) Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [General][Breaking] Remove APIs for reporting bundle download status to inspector-proxy, which does not use this information. Reviewed By: huntie Differential Revision: D52258567
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Dec 20, 2023
…41975) Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [General][Breaking] Remove APIs for reporting bundle download status to inspector-proxy, which does not use this information. Reviewed By: huntie Differential Revision: D52258567
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Dec 20, 2023
…41975) Summary: The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [General][Breaking] Remove APIs for reporting bundle download status to inspector-proxy, which does not use this information. Reviewed By: huntie Differential Revision: D52258567
|
This pull request has been merged in cfa02ee. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…41975) Summary: Pull Request resolved: facebook#41975 The version of `inspector-proxy` included with React Native has not used the `isLastBundleDownloadSuccess` and `bundleUpdateTimestamp` properties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building). Changelog: [General][Breaking] Remove APIs for reporting bundle download status to inspector-proxy, which does not use this information. Reviewed By: huntie Differential Revision: D52258567 fbshipit-source-id: e810278f949d8ab7dbc660cdc036a0f8464727f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The version of
inspector-proxyincluded with React Native has not used theisLastBundleDownloadSuccessandbundleUpdateTimestampproperties in years. This diff removes the backend support for reporting them (in preparation for a C++ rewrite of this infrastructure). We can consider bringing a similar feature back in the future on top of the modern CDP infra (which we are currently building).Changelog: [Internal]
Differential Revision: D52258567