Removing Fabric check from UIManagerProvider #41982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52273097 |
facebook-github-bot
force-pushed
the
export-D52273097
branch
from
76489a5 to
260c5e1
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
Summary: Moving the check for Fabric i.e. `ReactFeatureFlags.enableFabricRenderer` to old JSI Module path logic instead of new UIManagerProvider path for Fabric initialization and changing the default of UIManagerProvider from `null` -> `reactApplicationContext -> null;` since we are adding null check on the returned `UIManager` Differential Revision: D52273097
|
This pull request was exported from Phabricator. Differential Revision: D52273097 |
Base commit: 43826fa |
Summary: Moving the check for Fabric i.e. `ReactFeatureFlags.enableFabricRenderer` to old JSI Module path logic instead of new UIManagerProvider path for Fabric initialization and changing the default of UIManagerProvider from `null` -> `reactApplicationContext -> null;` since we are adding null check on the returned `UIManager` Slight change of design of API for JSI Module in order to address the issues faced due to `ReactFeatureFlags.enableFabricRenderer`, 1. Getting rid of this check for the new Fabric initialization and keeping the old JSI Module path intact. 2. Allowing the UIManager to be nullable so as to allow Twilight surface not have UIManager set even though they it succeeds in initializing the TwilightJSIModule. 3. As made the UIManager nullable, added the null check for the same. 4. This eradicates the dependency on this flag for Anna as well. Reviewed By: christophpurrer Differential Revision: D52273097
arushikesarwani94
force-pushed
the
export-D52273097
branch
from
260c5e1 to
133e32d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52273097 |
|
This pull request was successfully merged by Arushi Kesarwani in 1045b22. When will my fix make it into a release? | Upcoming Releases |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41982 Moving the check for Fabric i.e. `ReactFeatureFlags.enableFabricRenderer` to old JSI Module path logic instead of new UIManagerProvider path for Fabric initialization and changing the default of UIManagerProvider from `null` -> `reactApplicationContext -> null;` since we are adding null check on the returned `UIManager` Slight change of design of API for JSI Module in order to address the issues faced due to `ReactFeatureFlags.enableFabricRenderer`, 1. Getting rid of this check for the new Fabric initialization and keeping the old JSI Module path intact. 2. Allowing the UIManager to be nullable so as to allow Twilight surface not have UIManager set even though they it succeeds in initializing the TwilightJSIModule. 3. As made the UIManager nullable, added the null check for the same. 4. This eradicates the dependency on this flag for Anna as well. Reviewed By: christophpurrer Differential Revision: D52273097 fbshipit-source-id: bdf8b1de3771250c987c8f8bd4e48192f67a1afa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Moving the check for Fabric i.e.
ReactFeatureFlags.enableFabricRendererto old JSI Module path logic instead of new UIManagerProvider path for Fabric initialization and changing the default of UIManagerProvider fromnull->reactApplicationContext -> null;since we are adding null check on the returnedUIManagerDifferential Revision: D52273097