Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent LogBox from crashing on long messages (#38005) #41989

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Prevent LogBox from crashing on long messages (#38005) #41989

merged 3 commits into from
Dec 19, 2023

Commits on Dec 19, 2023

  1. Prevent LogBox from crashing on long messages (#38005) 

    Summary:
Pull Request resolved: #38005

Fixes #32093 by guarding the expensive `BABEL_CODE_FRAME_ERROR_FORMAT` regex with a cheaper initial scan. (Longer term, we should reduce our reliance on string parsing and propagate more structured errors.)

Changelog: [General][Fixed] Prevent LogBox from crashing on very long messages

Reviewed By: GijsWeterings

Differential Revision: D46892454

fbshipit-source-id: 3afadcdd75969c2589bbb06f47d1c4c1c2690abd
    @motiz88 @fortmarek
    motiz88 authored and fortmarek committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    b0291de View commit details
    Browse the repository at this point in the history

  2. Update RNTester Podfile.lock

    @fortmarek
    fortmarek committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    123c5b2 View commit details
    Browse the repository at this point in the history

  3. Check for major ruby version

    @fortmarek
    fortmarek committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    df6f15a View commit details
    Browse the repository at this point in the history