Change RN default position type to relative #42062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52137858 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 26, 2023
Summary: We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Differential Revision: D52137858
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 26, 2023
Summary: We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Differential Revision: D52137858
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 26, 2023
Summary: We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Differential Revision: D52137858
joevilches
force-pushed
the
export-D52137858
branch
from
a6a6d76 to
25efc8e
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 26, 2023
Summary: We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Differential Revision: D52137858
|
This pull request was exported from Phabricator. Differential Revision: D52137858 |
Base commit: 0e533f3 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 28, 2023
Summary: We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Differential Revision: D52137858
joevilches
force-pushed
the
export-D52137858
branch
from
25efc8e to
d329d5a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52137858 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 3, 2024
Summary: We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52137858
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 3, 2024
Summary: We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52137858
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 3, 2024
Summary: We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52137858
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 3, 2024
Summary: We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52137858
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 3, 2024
Summary: We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52137858
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 3, 2024
Summary: We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52137858
Summary: We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52137858
joevilches
force-pushed
the
export-D52137858
branch
from
d329d5a to
27540df
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52137858 |
|
This pull request has been merged in 348290b. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#42062 We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉 This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier. Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52137858 fbshipit-source-id: 6856bc608b8211c868c9ee81fc92e005ec3d2faa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have had relative as the default for a few big frameworks/apps right now (Fabric FB iOS, Fabric FB Android, OSS, Litho, CK) and have not run into issues. Seems it is safe to pull the trigger here and put everything on relative 🎉
This also fixes a test that relied on this default, changes the layout metrics default, and removes the gating plumbing that was in place earlier.
Lastly, a few animation tests start failing after this change. Seems that there is an animation bug with relative trees that would have existed already, so this is merely discovering that that bug exists, not causing any extra issues. Since that test is a set of random trees with random props it is very hard to debug and I am just adding skips to the failing ones.
Changelog: [Internal]
Differential Revision: D52137858