Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated RCTBundleURLProvider options #42114

Closed
wants to merge 1 commit into from
Closed

Remove deprecated RCTBundleURLProvider options #42114

wants to merge 1 commit into from

Conversation

Saadnajmi
Copy link
Contributor

Summary:

f7219ec deprecated some of the methods in `RCTBundleURLProvider, and is part of React Native version 0.73. Let's remove the deprecated options for React Native 0.74+

Changelog:

[IOS] [REMOVED] - Remove deprecated RCTBundleURLProvider options

Test Plan:

CI should pass.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 1, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,582,038 +4,081
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,955,040 -3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: f1a7f08
Branch: main

fkgozali
fkgozali reviewed Jan 2, 2024
View reviewed changes
packages/rn-tester/Podfile.lock Outdated

PODFILE CHECKSUM: 5afcf37691103b83159fb73be088b7cadc67af7b

COCOAPODS: 1.13.0
COCOAPODS: 1.14.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you accidentally upgraded CocoaPods version to use?

cc @cipolleschi - should we stick with 1.13.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we should revert the Podfile.lock, @Saadnajmi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Related, I can make a separate PR to update?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, because AFAIR, Cocoapods 1.14 only works with Ruby 3, and we still need to support Ruby 2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, but also, looks like 1.14.3 does support Ruby 2: https://github.com/CocoaPods/CocoaPods/releases/tag/1.14.3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, thanks for reporting! I think we can doing it for RNTester, but I won't do it for the template as this will force a non required migration to the whole ecosystem. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I can do that later. I don't think 1.14 has anything I need (visionOS is in 1.13 I believe).

@cipolleschi
Copy link
Contributor

/rebase - this should rebase on top of main

@cipolleschi
Copy link
Contributor

Could you rebase on top of main? The automatic rebase failed... :(
The CI errors should be gone now.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

Hi @Saadnajmi, heads up that I need to work on this PR internally, as there are parts of the internal codebase that are still using the deprecated methods. It will take a few days to land properly.

@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 016bb24.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 5, 2024
@Saadnajmi Saadnajmi deleted the remove branch January 5, 2024 20:17
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
@Saadnajmi @Othinn
Remove deprecated RCTBundleURLProvider options (facebook#42114)
49ab82f 
Summary:
facebook@f7219ec deprecated some of the methods in `RCTBundleURLProvider, and is part of React Native version 0.73. Let's remove the deprecated options for React Native 0.74+

bypass-github-export-checks

## Changelog:

[IOS] [REMOVED] - Remove deprecated RCTBundleURLProvider options

Pull Request resolved: facebook#42114

Test Plan: CI should pass.

Reviewed By: huntie

Differential Revision: D52537732

Pulled By: cipolleschi

fbshipit-source-id: ea5d17c7c66a60bceb2a12f2e17e39be4c56d422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi left review comments

@fkgozali fkgozali fkgozali left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Saadnajmi @analysis-bot @cipolleschi @facebook-github-bot @fkgozali