Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Float and Int type support for iOS modules #42125

Closed
wants to merge 1 commit into from
Closed

Add Float and Int type support for iOS modules #42125

wants to merge 1 commit into from

Conversation

dmytrorykun
Copy link
Contributor

Summary:
This diff changes how numeric types are generated for Objective-C native modules.
Before this diff:

Codegen Type Objective-C Type
number double
Float double
Double double
Int32 double
After this diff:
Codegen Type Objective-C Type
-- --
number double
Float float
Double double
Int32 NSInteger

Changelog: [iOS][Breaking] - Codegen: mapping for numeric types is changed for Objective-C native modules. Float -> float; Int32 -> NSInteger.

Differential Revision: D52479442

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52479442

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Jan 2, 2024
@dmytrorykun @facebook-github-bot
Add Float and Int type support for iOS modules (facebook#42125)
507170b 
Summary:

This diff changes how numeric types are generated for Objective-C native modules.
Before this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|double|
|Double|double|
|Int32|double|
After this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|**float**|
|Double|double|
|Int32|**NSInteger**|

Changelog: [iOS][Breaking] - Codegen: mapping for numeric types is changed for Objective-C native modules. `Float` -> `float`; `Int32` -> `NSInteger`.

Differential Revision: D52479442
@analysis-bot
Copy link

analysis-bot commented Jan 2, 2024 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,578,094 -5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,955,038 -12
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: b81a081
Branch: main

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Jan 3, 2024
@dmytrorykun @facebook-github-bot
Add Float and Int type support for iOS modules (facebook#42125)
682ccf7 
Summary:

This diff changes how numeric types are generated for Objective-C native modules.
Before this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|double|
|Double|double|
|Int32|double|
After this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|**float**|
|Double|double|
|Int32|**NSInteger**|

Changelog: [iOS][Breaking] - Codegen: mapping for numeric types is changed for Objective-C native modules. `Float` -> `float`; `Int32` -> `NSInteger`.

Differential Revision: D52479442
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Jan 3, 2024
@dmytrorykun @facebook-github-bot
Add Float and Int type support for iOS modules (facebook#42125)
dfdc71e 
Summary:

This diff changes how numeric types are generated for Objective-C native modules.
Before this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|double|
|Double|double|
|Int32|double|
After this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|**float**|
|Double|double|
|Int32|**NSInteger**|

Changelog: [iOS][Breaking] - Codegen: mapping for numeric types is changed for Objective-C native modules. `Float` -> `float`; `Int32` -> `NSInteger`.

Differential Revision: D52479442
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52479442

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Jan 3, 2024
@dmytrorykun @facebook-github-bot
Add Float and Int type support for iOS modules (facebook#42125)
26fce60 
Summary:

This diff changes how numeric types are generated for Objective-C native modules.
Before this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|double|
|Double|double|
|Int32|double|
After this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|**float**|
|Double|double|
|Int32|**NSInteger**|

Changelog: [iOS][Breaking] - Codegen: mapping for numeric types is changed for Objective-C native modules. `Float` -> `float`; `Int32` -> `NSInteger`.

Reviewed By: cipolleschi

Differential Revision: D52479442
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Jan 4, 2024
@dmytrorykun @facebook-github-bot
Add Float and Int type support for iOS modules (facebook#42125)
2819fdc 
Summary:

This diff changes how numeric types are generated for Objective-C native modules.
Before this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|double|
|Double|double|
|Int32|double|
After this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|**float**|
|Double|double|
|Int32|**NSInteger**|

Changelog: [iOS][Breaking] - Codegen: mapping for numeric types is changed for Objective-C native modules. `Float` -> `float`; `Int32` -> `NSInteger`.

Reviewed By: cipolleschi

Differential Revision: D52479442
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52479442

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Jan 4, 2024
@dmytrorykun @facebook-github-bot
[skip ci] Add Float and Int type support for iOS modules (facebook#42125
f58a664 
)

Summary:

This diff changes how numeric types are generated for Objective-C native modules.
Before this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|double|
|Double|double|
|Int32|double|
After this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|**float**|
|Double|double|
|Int32|**NSInteger**|

Changelog: [iOS][Breaking] - Codegen: mapping for numeric types is changed for Objective-C native modules. `Float` -> `float`; `Int32` -> `NSInteger`.

Reviewed By: cipolleschi

Differential Revision: D52479442
@dmytrorykun @facebook-github-bot
Add Float and Int type support for iOS modules (facebook#42125)
1f7bb6d 
Summary:

This diff changes how numeric types are generated for Objective-C native modules.
Before this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|double|
|Double|double|
|Int32|double|
After this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|**float**|
|Double|double|
|Int32|**NSInteger**|

Changelog: [iOS][Breaking] - Codegen: mapping for numeric types is changed for Objective-C native modules. `Float` -> `float`; `Int32` -> `NSInteger`.

Reviewed By: cipolleschi

Differential Revision: D52479442
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52479442

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 4, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5aa425c.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
@dmytrorykun @Othinn
Add Float and Int type support for iOS modules (facebook#42125)
8eb8b78 
Summary:
Pull Request resolved: facebook#42125

This diff changes how numeric types are generated for Objective-C native modules.
Before this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|double|
|Double|double|
|Int32|double|
After this diff:
|Codegen Type|Objective-C Type|
| -- | -- |
|number|double|
|Float|**float**|
|Double|double|
|Int32|**NSInteger**|

Changelog: [iOS][Breaking] - Codegen: mapping for numeric types is changed for Objective-C native modules. `Float` -> `float`; `Int32` -> `NSInteger`.

Reviewed By: cipolleschi

Differential Revision: D52479442

fbshipit-source-id: 1b2e101a9593a75c7c19b0da3a01a0e592a35ba5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmytrorykun @facebook-github-bot @analysis-bot