Remove suppressions for Wgnu-zero-variadic-macro-arguments #42136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52534129 |
Base commit: e4708d6 |
|
This pull request was exported from Phabricator. Differential Revision: D52534129 |
NickGerleman
force-pushed
the
export-D52534129
branch
from
c9d17d4 to
1bfd92a
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 4, 2024
…42136) Summary: Pull Request resolved: facebook#42136 `Wpedantic` flags usage of variadic macros with zero arguments. This is widely supported by different compilers (including MSVC), but was previously forbidden by the standard. C++ 20 explicitly allows them, so, theoretically Clang should know not to warn about these now. Let's try that. Changelog: [Internal] Differential Revision: D52534129 fbshipit-source-id: 1a951fef553ea4dc54ed71d44374da408dcc1f0a
…42136) Summary: Pull Request resolved: facebook#42136 `Wpedantic` flags usage of variadic macros with zero arguments. This is widely supported by different compilers (including MSVC), but was previously forbidden by the standard. C++ 20 explicitly allows them, so, theoretically Clang should know not to warn about these now. Let's try that. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52534129 fbshipit-source-id: 86c2ade4c654c9bf9fa08776c944e141dcd7df0e
|
This pull request was exported from Phabricator. Differential Revision: D52534129 |
NickGerleman
force-pushed
the
export-D52534129
branch
from
1bfd92a to
a711963
Compare
|
This pull request has been merged in 7c444de. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…42136) Summary: Pull Request resolved: facebook#42136 `Wpedantic` flags usage of variadic macros with zero arguments. This is widely supported by different compilers (including MSVC), but was previously forbidden by the standard. C++ 20 explicitly allows them, so, theoretically Clang should know not to warn about these now. Let's try that. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52534129 fbshipit-source-id: e27a75081fac6b4196c6dbb5242812877b0bd679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Wpedanticflags usage of variadic macros with zero arguments. This is widely supported by different compilers (including MSVC), but was previously forbidden by the standard.C++ 20 explicitly allows them, so, theoretically Clang should know not to warn about these now. Let's try that.
Changelog: [Internal]
Differential Revision: D52534129