Refactor: ReactHost: Remove new prefix from task creation methods #42169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52495531 |
RSNara
force-pushed
the
export-D52495531
branch
from
765dbcc to
165bafe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52495531 |
RSNara
force-pushed
the
export-D52495531
branch
from
165bafe to
f1075b9
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…cebook#42169) Summary: Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D52495531
|
This pull request was exported from Phabricator. Differential Revision: D52495531 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…cebook#42169) Summary: Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D52495531
RSNara
force-pushed
the
export-D52495531
branch
from
f1075b9 to
68e7e10
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52495531 |
… getOrCreateReactInstance Summary: This will help avoid a name collision when we remove the new suffix from newGetOrCreateReactInstanceTask. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D52495532
…rCreateStartTask Summary: Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D52495535
…the ReactHost thread Summary: Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D52495534
…book#42168) Summary: Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D52495533
…cebook#42169) Summary: Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D52495531
RSNara
force-pushed
the
export-D52495531
branch
from
68e7e10 to
a6f38fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52495531 |
Base commit: 0fd7bd3 |
|
This pull request has been merged in 7f2529d. |
gokul1099
pushed a commit
to gokul1099/react-native-visionos
that referenced
this pull request
Jan 17, 2024
…cebook#42169) Summary: Pull Request resolved: facebook#42169 Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D52495531 fbshipit-source-id: 2651b462a0dba437c8652fefd38421f2d826935a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Internal]
Differential Revision: D52495531