Properly handle Xcode targets with spaces in their names #42220
Conversation
Use quotes around the argument to basename path. Ensures this succeeds when the Xcode target name has spaces.
|
Hi @paulschreiber! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Base commit: 7f2529d |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
CLA Signed
|
@arushikesarwani94 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@arushikesarwani94 merged this pull request in 63e893d. |
) Summary: Properly handle targets with spaces in their names Use quotes around the argument to basename path. Ensures this succeeds when the Xcode target name has spaces. example: ```sh #!/bin/sh SOURCEMAP_FILE="ArchiveIntermediates/Jane Doe/IntermediateBuildFilesPath/Jane Doe.build/Release-iphoneos/JaneDoe.build/DerivedSources/main.jsbundle.map" BN_SOURCEMAP_FILE="$(basename $SOURCEMAP_FILE)" echo $BN_SOURCEMAP_FILE ``` output: ``` Jane Jane main.jsbundle.map ``` ```sh #!/bin/sh SOURCEMAP_FILE="ArchiveIntermediates/Jane Doe/IntermediateBuildFilesPath/Jane Doe.build/Release-iphoneos/JaneDoe.build/DerivedSources/main.jsbundle.map" BN_SOURCEMAP_FILE="$(basename "$SOURCEMAP_FILE")" echo $BN_SOURCEMAP_FILE ``` output: ``` main.jsbundle.map ``` ## Changelog: [iOS] [Fixed] - Fix support for SOURCEMAP_FILE path containing spaces ## Related facebook#40937 Pull Request resolved: facebook#42220 Reviewed By: christophpurrer Differential Revision: D52650491 Pulled By: arushikesarwani94 fbshipit-source-id: e42b8a0d018b37fb558abd53d765fbdd676c51a2
Summary: Properly handle targets with spaces in their names Use quotes around the argument to basename path. Ensures this succeeds when the Xcode target name has spaces. example: ```sh #!/bin/sh SOURCEMAP_FILE="ArchiveIntermediates/Jane Doe/IntermediateBuildFilesPath/Jane Doe.build/Release-iphoneos/JaneDoe.build/DerivedSources/main.jsbundle.map" BN_SOURCEMAP_FILE="$(basename $SOURCEMAP_FILE)" echo $BN_SOURCEMAP_FILE ``` output: ``` Jane Jane main.jsbundle.map ``` ```sh #!/bin/sh SOURCEMAP_FILE="ArchiveIntermediates/Jane Doe/IntermediateBuildFilesPath/Jane Doe.build/Release-iphoneos/JaneDoe.build/DerivedSources/main.jsbundle.map" BN_SOURCEMAP_FILE="$(basename "$SOURCEMAP_FILE")" echo $BN_SOURCEMAP_FILE ``` output: ``` main.jsbundle.map ``` ## Changelog: [iOS] [Fixed] - Fix support for SOURCEMAP_FILE path containing spaces ## Related #40937 Pull Request resolved: #42220 Reviewed By: christophpurrer Differential Revision: D52650491 Pulled By: arushikesarwani94 fbshipit-source-id: e42b8a0d018b37fb558abd53d765fbdd676c51a2
Summary:
Properly handle targets with spaces in their names
Use quotes around the argument to basename path. Ensures this succeeds when the Xcode target name has spaces.
example:
output:
output:
Changelog:
[iOS] [Fixed] - Fix support for SOURCEMAP_FILE path containing spaces
Related
#40937