Restore RCT_NEW_ARCH_ENABLED semantics for backward compatibility #42259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52727792 |
Base commit: 0dd27f2 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 12, 2024
…cebook#42259) Summary: At the end of last year, we reduce build fragmentation in iOS making sure that we were always building both architecture. In the process, we break the semantic od RCt_NEW_ARCH_ENABLED flag, making several libs stop working in one of the two archs. This change should restore the semantic, so libraries that were using RCT_NEW_ARCH_ENABLED to run conditional code will still work in the same way. While doing so, I also removed the new USE_NEW_ARCH as we don't want unnecessary flags ## CHANGELOG: [iOS][Fixed] - Bring the old RCT_NEW_ARCH_ENABLED semantic back for compatibility Differential Revision: D52727792
cipolleschi
force-pushed
the
export-D52727792
branch
from
fcef9bc to
a502447
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52727792 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 12, 2024
…cebook#42259) Summary: At the end of last year, we reduce build fragmentation in iOS making sure that we were always building both architecture. In the process, we break the semantic od RCt_NEW_ARCH_ENABLED flag, making several libs stop working in one of the two archs. This change should restore the semantic, so libraries that were using RCT_NEW_ARCH_ENABLED to run conditional code will still work in the same way. While doing so, I also removed the new USE_NEW_ARCH as we don't want unnecessary flags ## CHANGELOG: [iOS][Fixed] - Bring the old RCT_NEW_ARCH_ENABLED semantic back for compatibility Reviewed By: cortinico Differential Revision: D52727792
cipolleschi
force-pushed
the
export-D52727792
branch
from
a502447 to
129dea4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52727792 |
…cebook#42259) Summary: At the end of last year, we reduce build fragmentation in iOS making sure that we were always building both architecture. In the process, we break the semantic od RCt_NEW_ARCH_ENABLED flag, making several libs stop working in one of the two archs. This change should restore the semantic, so libraries that were using RCT_NEW_ARCH_ENABLED to run conditional code will still work in the same way. While doing so, I also removed the new USE_NEW_ARCH as we don't want unnecessary flags ## CHANGELOG: [iOS][Fixed] - Bring the old RCT_NEW_ARCH_ENABLED semantic back for compatibility Reviewed By: cortinico Differential Revision: D52727792
cipolleschi
force-pushed
the
export-D52727792
branch
from
129dea4 to
84ff1a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52727792 |
|
This pull request has been merged in 3690e44. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
At the end of last year, we reduce build fragmentation in iOS making sure that we were always building both architecture.
In the process, we break the semantic od RCt_NEW_ARCH_ENABLED flag, making several libs stop working in one of the two archs.
This change should restore the semantic, so libraries that were using RCT_NEW_ARCH_ENABLED to run conditional code will still work in the same way. While doing so, I also removed the new USE_NEW_ARCH as we don't want unnecessary flags
CHANGELOG:
[iOS][Fixed] - Bring the old RCT_NEW_ARCH_ENABLED semantic back for compatibility
Differential Revision: D52727792