CustomLineHeightSpan: Increase the readability
#42592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...by making the logic less stateful.
facebook-github-bot
added
CLA Signed
|
@strindhaug Any chance you could review this? |
Base commit: 6d77d7b |
cubuspl42
commented
Jan 22, 2024
| fm.bottom += Math.floor(additional / 2.0f); | ||
| fm.ascent = fm.top; | ||
| fm.descent = fm.bottom; | ||
| final int top = (int) (fm.top - Math.ceil(additional / 2.0f)); |
There was a problem hiding this comment.
Well, as I look at it now, the (int) conversion could be put inside the parens for literal 1:1 equivalence
mdvacca
approved these changes
Jan 24, 2024
|
@mdvacca has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Increase the readability of
CustomLineHeightSpanby making the logic less stateful.This is a minor improvement in the context of my multi-PR work on react-native-community/discussions-and-proposals#695.
Changelog:
[INTERNAL] [CHANGED] - Increase the readability of
CustomLineHeightSpanTest Plan:
lineHeightdoesn't change