Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCTAttributedTextUtils.mm: Split NSAttributedString creation #42595

Closed
wants to merge 1 commit into from
Closed

RCTAttributedTextUtils.mm: Split NSAttributedString creation #42595

wants to merge 1 commit into from

Conversation

cubuspl42
Copy link
Contributor

Summary:

RCTAttributedTextUtils.mm: Split NSAttributedString creation to functions in preparation for adding new logic here.

This is a minor improvement in the context of my multi-PR work on react-native-community/discussions-and-proposals#695.

Changelog:

[INTERNAL] [CHANGE] - Refactor NSAttributedString creation in RCTAttributedTextUtils.mm

Test Plan:

@cubuspl42
RCTAttributedTextUtils.mm: Split NSAttributedString creation to f…
a9722ba 
…unctions

...in preparation for adding new logic here.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 22, 2024
@cubuspl42
Copy link
Contributor Author

@sammy-SC Any chance you could review this?

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,951,065 +5,882
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,334,837 +2,337
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 6d77d7b
Branch: main

@cubuspl42 cubuspl42 mentioned this pull request Jan 23, 2024
Open
@cubuspl42
Copy link
Contributor Author

@sammy-SC ...but if you could recommend some Objective-C expert from the React Native team, I would also be grateful! 😃

@facebook-github-bot
Copy link
Contributor

@sammy-SC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cipolleschi
cipolleschi approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cubuspl42, thanks for your contribution!

@cubuspl42
Copy link
Contributor Author

cubuspl42 commented Jan 23, 2024 •
edited
Loading

@cipolleschi

Thank you!

You'll thank me later; non-trivial PRs will come after this wave.

Currently, the wave progress is 2/6. I would be extremely grateful for taking a look at maybe one more:

#42602 (comment)

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 25, 2024
@facebook-github-bot
Copy link
Contributor

@sammy-SC merged this pull request in 2dc2d4d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cubuspl42 @analysis-bot @facebook-github-bot @cipolleschi