Clean up the function naming in TextMeasureCache.h
#42598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One name was clearly a human mistake. Make the naming consistent.
facebook-github-bot
added
CLA Signed
|
@christophpurrer Any chance you could review this? |
Base commit: 6d77d7b |
|
@sammy-SC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cubuspl42
commented
Jan 22, 2024
| @@ -141,7 +141,7 @@ inline bool areAttributedStringFragmentsEquivalentLayoutWise( | |||
| rhs.parentShadowView.layoutMetrics)); | |||
| } | |||
|
|
|||
| inline size_t textAttributesHashLayoutWise( | |||
There was a problem hiding this comment.
This was the human mistake; it's a hash for AttributedString::Fragment, not for TextAttributes
cubuspl42
commented
Jan 22, 2024
| @@ -171,12 +171,12 @@ inline bool areAttributedStringsEquivalentLayoutWise( | |||
| return true; | |||
| } | |||
|
|
|||
| inline size_t textAttributedStringHashLayoutWise( | |||
| inline size_t attributedStringHashLayoutWise( | |||
There was a problem hiding this comment.
This is the rename for the sake of consistency
|
Thanks for assigning yourself! Let me know what you think. It's a very trivial change, but I wanted to make it separate so it's clear what is being changed and why. Sorry about the failing lint; is this related to line lengths? Is there a simple way to fix it? Why is "Builds & Tests" failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Clean up the function naming in
TextMeasureCache.h. One name was clearly a human mistake. Make the naming consistent.This is a minor improvement in the context of my multi-PR work on react-native-community/discussions-and-proposals#695.
Changelog:
[INTERNAL] [CHANGE] - Clean up the function naming in
TextMeasureCache.hTest Plan: