Fix crash in the interop layer when components emits events as soon as are created #42743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
cipolleschi
force-pushed
the
export-D53230471
branch
from
824c2ed to
febe9af
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Differential Revision: D53230471
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Differential Revision: D53230471
cipolleschi
force-pushed
the
export-D53230471
branch
from
febe9af to
40c1722
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Differential Revision: D53230471
cipolleschi
force-pushed
the
export-D53230471
branch
from
40c1722 to
ebd5500
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Differential Revision: D53230471
cipolleschi
force-pushed
the
export-D53230471
branch
from
ebd5500 to
0f44514
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Reviewed By: sammy-SC Differential Revision: D53230471
cipolleschi
force-pushed
the
export-D53230471
branch
from
0f44514 to
108bfee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
cipolleschi
force-pushed
the
export-D53230471
branch
from
108bfee to
05ca59c
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Reviewed By: sammy-SC Differential Revision: D53230471
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Reviewed By: sammy-SC Differential Revision: D53230471
cipolleschi
force-pushed
the
export-D53230471
branch
from
05ca59c to
2d4ff4c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Reviewed By: sammy-SC Differential Revision: D53230471
cipolleschi
force-pushed
the
export-D53230471
branch
from
2d4ff4c to
b3e8e2b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
cipolleschi
force-pushed
the
export-D53230471
branch
from
b3e8e2b to
3d59407
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Reviewed By: sammy-SC Differential Revision: D53230471
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Reviewed By: sammy-SC Differential Revision: D53230471
cipolleschi
force-pushed
the
export-D53230471
branch
from
3d59407 to
1e7ef5c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Reviewed By: sammy-SC Differential Revision: D53230471
cipolleschi
force-pushed
the
export-D53230471
branch
from
1e7ef5c to
d8128f0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Reviewed By: sammy-SC Differential Revision: D53230471
cipolleschi
force-pushed
the
export-D53230471
branch
from
d8128f0 to
37511e4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
…s are created (facebook#42743) Summary: When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer. The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash. There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created. ## Changelog: [iOS][Fixed] - Immediately set props of Components that goes through the interop layer Reviewed By: sammy-SC Differential Revision: D53230471
cipolleschi
force-pushed
the
export-D53230471
branch
from
37511e4 to
a052e27
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53230471 |
|
This pull request has been merged in 68ae8cd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When working on Mobile Home, we found a component (RNCSafeAreaView) that was going through the interop layer.
The component eits an event as soon as its content view changes, but this is too early: the block that emits the event is still nil at that point in time and that makes the app crash.
There might be other components with similarbehavior, therefore, we are fixing it at the interop layer, setting the props immediately after the component is created.
Changelog:
[iOS][Fixed] - Immediately set props of Components that goes through the interop layer
Differential Revision: D53230471