hide "Open Debugger" item when using local bundle #42873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53354110 |
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Feb 5, 2024
…42873) Summary: Changelog: [iOS][Fixed] Disable the "Open Debugger" item from dev menu if packager is disconnected # Existing In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected. {F1434746954} # In this PR The "Open Debugger" menu item is disabled when the packager is disconnected. {F1451344668} # Reference * Also on Android: D53428914 Differential Revision: D53354110
EdmondChuiHW
force-pushed
the
export-D53354110
branch
from
3120166
to
3a72d6b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53354110 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53354110 |
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Feb 5, 2024
…42873) Summary: Changelog: [iOS][Fixed] Disable the "Open Debugger" item from dev menu if packager is disconnected # Existing In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected. {F1434746954} # In this PR The "Open Debugger" menu item is disabled when the packager is disconnected. {F1451344668} # Reference * Also on Android: D53428914 Differential Revision: D53354110
EdmondChuiHW
force-pushed
the
export-D53354110
branch
from
3a72d6b
to
694104d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53354110 |
…42873) Summary: Changelog: [iOS][Fixed] Disable the "Open Debugger" item from dev menu if packager is disconnected # Existing In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected. {F1434746954} # In this PR The "Open Debugger" menu item is disabled when the packager is disconnected. {F1451344668} # Reference * Also on Android: D53428914 Reviewed By: robhogan Differential Revision: D53354110
EdmondChuiHW
force-pushed
the
export-D53354110
branch
from
694104d
to
6918e9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53354110 |
|
This pull request has been merged in bc3fe0d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[iOS][Fixed] Hide the "Open Debugger" item from dev menu if the bundle is local
Existing
In our dev menu, the "Open Debugger" menu item is shown even if Metro isn't connected.
{F1434746954}
In this PR
The "Open Debugger" menu item is disabled when Metro is disconnected.
Connect to Metro to debug JavaScript
{F1451344668}
Differential Revision: D53354110