Generate the RCTModulesConformingToProtocolsProvider only for react-native core #43046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53807045 |
…ative core (facebook#43046) Summary: This fixes a problem where RCTModulesConformingToProtocolsProvider was generated also in Library space. ## Changelog: [iOS][Fixed] - Generate the RCTModulesConformingToProtocolsProvider only once in user space ## Facebook See comment [here](https://www.internalfb.com/diff/D53441411?dst_version_fbid=750944970297544&transaction_fbid=719673583317629) Reviewed By: dmytrorykun Differential Revision: D53807045
cipolleschi
force-pushed
the
export-D53807045
branch
from
756f3ae to
c689553
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53807045 |
Base commit: 59d46e8 |
|
This pull request has been merged in a3998f8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes a problem where RCTModulesConformingToProtocolsProvider was generated also in Library space.
Changelog:
[iOS][Fixed] - Generate the RCTModulesConformingToProtocolsProvider only once in user space
Facebook
See comment here
Reviewed By: dmytrorykun
Differential Revision: D53807045