Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.75] Add support for handling com.facebook.react.bridge.Dynamic as parameter for TurboModules #46066

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

cortinico
Copy link
Contributor

Summary:
Pull Request resolved: #45944

This diff adds support having (Legacy) Native Modules with functions with parameters of type Dynamic. This is currently blocking some libraries making it harder for them to migrate to New Architecture.

I've implemented it by adding a DynamicNative implementation of Dynamic which holds a reference of the payload as a folly::dynamic.

Changelog:
[Android] [Added] - Add support for handling com.facebook.react.bridge.Dynamic as parameter type in TurboModules

Reviewed By: mdvacca, cipolleschi

Differential Revision: D60966684

fbshipit-source-id: 2e63bc53ede5277a9c12f1b19f05f6099f5f35f9

…eter type in TurboModules (#45944)

Summary:
Pull Request resolved: #45944

This diff adds support having (Legacy) Native Modules with functions with parameters of type `Dynamic`.
This is currently blocking some libraries making it harder for them to migrate to New Architecture.

I've implemented it by adding a `DynamicNative` implementation of `Dynamic` which holds a reference of
the payload as a `folly::dynamic`.

Changelog:
[Android] [Added] - Add support for handling `com.facebook.react.bridge.Dynamic` as parameter type in TurboModules

Reviewed By: mdvacca, cipolleschi

Differential Revision: D60966684

fbshipit-source-id: 2e63bc53ede5277a9c12f1b19f05f6099f5f35f9
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 16, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,743,773 -611,083
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,945,508 -604,483
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fcd526d
Branch: main

@blakef blakef merged commit 45cd817 into 0.75-stable Aug 19, 2024
90 of 91 checks passed
@blakef blakef deleted the nc/pick-dynamic-075 branch August 19, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants