[iOS] Geolocation Accuracy and Cached Location Bug #6198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @nicklockwood, @brentvatne and @zjj010104 to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Does this line need to updated to reflect your changes? |
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
|
@christopherdro |
christopherdro
pushed a commit
to wildlifela/react-native
that referenced
this pull request
Mar 9, 2016
Summary:There are two issues: 1. When calling startObserving or getCurrentPosition for the first time, _locationManager is not initialized and the accuracy value set in options is lost. 2. When using the cached location _lastLocationEvent, current timestamp retrieved by CFAbsoluteTimeGetCurrent() is from 2001, but the timestamp of the location is from 1970. In addition, the comparison between _lastLocationEvent[@"coords"][@"accuracy"] and options.accuracy is incorrect. Less value indicates more accurate location. Closes facebook#6198 Differential Revision: D3023786 Pulled By: nicklockwood fb-gh-sync-id: 869c0e34252470275bf99cf0e5861747247f1158 shipit-source-id: 869c0e34252470275bf99cf0e5861747247f1158
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
Summary:There are two issues: 1. When calling startObserving or getCurrentPosition for the first time, _locationManager is not initialized and the accuracy value set in options is lost. 2. When using the cached location _lastLocationEvent, current timestamp retrieved by CFAbsoluteTimeGetCurrent() is from 2001, but the timestamp of the location is from 1970. In addition, the comparison between _lastLocationEvent[@"coords"][@"accuracy"] and options.accuracy is incorrect. Less value indicates more accurate location. Closes facebook#6198 Differential Revision: D3023786 Pulled By: nicklockwood fb-gh-sync-id: 869c0e34252470275bf99cf0e5861747247f1158 shipit-source-id: 869c0e34252470275bf99cf0e5861747247f1158
machard
pushed a commit
to machard/react-native
that referenced
this pull request
Mar 22, 2016
Summary:There are two issues: 1. When calling startObserving or getCurrentPosition for the first time, _locationManager is not initialized and the accuracy value set in options is lost. 2. When using the cached location _lastLocationEvent, current timestamp retrieved by CFAbsoluteTimeGetCurrent() is from 2001, but the timestamp of the location is from 1970. In addition, the comparison between _lastLocationEvent[@"coords"][@"accuracy"] and options.accuracy is incorrect. Less value indicates more accurate location. Closes facebook#6198 Differential Revision: D3023786 Pulled By: nicklockwood fb-gh-sync-id: 869c0e34252470275bf99cf0e5861747247f1158 shipit-source-id: 869c0e34252470275bf99cf0e5861747247f1158
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues: