Core Components Tutorial to ES6 (master) #8213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same changes as the previous PR (#8198), but on the master branch as requested.
|
By analyzing the blame information on this pull request, we identified @JoelMarcey and @stevemao to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@Ehesp Hey! Sorry about this, but I broke up the core component tutorial into separate pieces. So now |
| var ds = new ListView.DataSource({rowHasChanged: (r1, r2) => r1 !== r2}); | ||
| return { | ||
| dataSource: ds.cloneWithRows(['John', 'Joel', 'James', 'Jimmy', 'Jackson', 'Jillian', 'Julie']) | ||
| constructor() { |
There was a problem hiding this comment.
should you include props to your constructor call?
constructor(props) {
super(props);
...
}
|
I created a new pull request on the latest work that converted I am going to close this one out for now. Let me know if you have any questions. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same changes as the previous PR (#8198), but on the master branch as requested.