Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change method name color for API/Component methods #8481

Closed
wants to merge 1 commit into from
Closed

Change method name color for API/Component methods #8481

wants to merge 1 commit into from

Conversation

JoelMarcey
Copy link

Test Plan:

Old:

screenshot 2016-06-28 18 16 03

New:

screenshot 2016-06-28 18 17 05

@ghost
Copy link

ghost commented Jun 29, 2016

By analyzing the blame information on this pull request, we identified @Andreyco and @caabernathy to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 29, 2016
@JoelMarcey
Copy link
Author

I am just going to land this so I can cherry-pick this and the NavigationExperimental tutorial into 0.29 -- and then we can officially close this lockdown out, I think :)

@JoelMarcey
Copy link
Author

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jun 29, 2016
@ghost
Copy link

ghost commented Jun 29, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in bcb7cc4 Jun 29, 2016
bestander pushed a commit that referenced this pull request Jun 29, 2016
@JoelMarcey @bestander
Additional docdown commits to 0.29 (#8492)
17b1272 
* Initial stab at NavigationExperimental tutorial

Summary:
Add a NavigationExperimental section to the Navigation guide.

![navexp](https://cloud.githubusercontent.com/assets/165856/16355280/120e7d38-3a67-11e6-9567-51c19c249fdf.png)
Closes #8431

Differential Revision: D3493158

Pulled By: JoelMarcey

fbshipit-source-id: 5e9646c3abf97f5cce6f5ba5b3d10853aa84ee8e

* Change method name color for API/Component methods

Summary: Closes #8481

Differential Revision: D3497267

Pulled By: JoelMarcey

fbshipit-source-id: 82ffb17a9ec3110481ad64d5065fc9fee6a31808
bubblesunyum pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
@JoelMarcey @bubblesunyum
Change method name color for API/Component methods
7a882a8 
Summary: Closes facebook#8481

Differential Revision: D3497267

Pulled By: JoelMarcey

fbshipit-source-id: 82ffb17a9ec3110481ad64d5065fc9fee6a31808
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
@JoelMarcey
Change method name color for API/Component methods
04f4115 
Summary: Closes facebook#8481

Differential Revision: D3497267

Pulled By: JoelMarcey

fbshipit-source-id: 82ffb17a9ec3110481ad64d5065fc9fee6a31808
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caabernathy caabernathy

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoelMarcey @caabernathy