Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick in 0.29: Specify width and height for Image(remote source) #8514

Merged
merged 1 commit into from
Jun 30, 2016
Merged

Cherry-pick in 0.29: Specify width and height for Image(remote source) #8514

merged 1 commit into from
Jun 30, 2016

Conversation

JoelMarcey
Copy link

Summary:

Better for doc examples

Original commit: 6b2a49e

Summary: Closes #8486

Differential Revision: D3496850

Pulled By: javache

fbshipit-source-id: f2456b914c420089558484fb87e3d92ed2c923af
@ghost
Copy link

ghost commented Jun 30, 2016

By analyzing the blame information on this pull request, we identified @lacker and @sunnylqm to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 30, 2016
@lacker
Copy link
Contributor

lacker commented Jun 30, 2016

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jun 30, 2016
@ghost
Copy link

ghost commented Jun 30, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@JoelMarcey
Copy link
Author

Ah -- we don't use the shipit bot for cherry-picks into non-master branches. You just do direct merges.

@JoelMarcey JoelMarcey merged commit 14bb6fa into facebook:0.29-stable Jun 30, 2016
@JoelMarcey
Copy link
Author

cc @grabbou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants