Add post documentation lockdown survey link #8530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did a survey prior to the doc lockdown to get an idea of what we should focus on. Now we have a yes/no style survey to ensure that we met the user needs when it came to our start of improving the docs. This diff adds the survey link to the bottom of each page. And we will cherry-pick it into 0.29 as well, which will be the first official release with the new doc content > **NOTE**: The content via the links in this survey will not > be valid until 0.29 is actually released. So I have not enabled > the questions for the survey until then. Test Plan: http://localhost:8079/react-native/docs/getting-started.html
|
By analyzing the blame information on this pull request, we identified @Andreyco and @caabernathy to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
| <div className="survey"> | ||
| <div className="survey-image" /> | ||
| <p> | ||
| We just had a lockdown to improve the React Native documentation. Your responses to this yes/no style survey will help us gauge whether we moved in the right direction with the improvements. Thank you! |
There was a problem hiding this comment.
Is the term 'lockdown' used in a similar manner outside of FB? Maybe go with similar wording as the blog post:
"Recently we've been working hard to make the docs better based on your feedback. Your responses to this yes/no style survey will help us gauge whether we moved in the right direction with the improvements. Thank you!"
|
LGTM. Minor nit regarding the use of lockdown but I don't feel too strongly about it. |
|
@hramos Ah - good point. Fixed. |
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Something went wrong when importing this pull request. Please cc someone from the team at fb to help with importing this. |
ghost
added
Import Failed
and removed
Import Started
|
@facebook-github-bot shipit |
ghost
added
the
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: We did a survey prior to the doc lockdown to get an idea of what we should focus on. Now we have a yes/no style survey to ensure that we met the user needs when it came to our start of improving the docs. This diff adds the survey link to the bottom of each page. And we will cherry-pick it into 0.29 as well, which will be the first official release with the new doc content > **NOTE**: The content via the links in this survey will not be valid until 0.29 is actually released. So I have not enabled the questions for the survey until then. **Test Plan:** http://localhost:8079/react-native/docs/getting-started.html <img width="753" alt="screenshot 2016-07-01 17 35 17" src="https://cloud.githubusercontent.com/assets/3757713/16535354/987dd3a8-3fb4-11e6-81b7-1a1fcffd3bb2.png"> Closes facebook#8530 Differential Revision: D3515242 Pulled By: JoelMarcey fbshipit-source-id: c2d241d472853dfb3f9e7d3ae9560b318aacb866
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: We did a survey prior to the doc lockdown to get an idea of what we should focus on. Now we have a yes/no style survey to ensure that we met the user needs when it came to our start of improving the docs. This diff adds the survey link to the bottom of each page. And we will cherry-pick it into 0.29 as well, which will be the first official release with the new doc content > **NOTE**: The content via the links in this survey will not be valid until 0.29 is actually released. So I have not enabled the questions for the survey until then. **Test Plan:** http://localhost:8079/react-native/docs/getting-started.html <img width="753" alt="screenshot 2016-07-01 17 35 17" src="https://cloud.githubusercontent.com/assets/3757713/16535354/987dd3a8-3fb4-11e6-81b7-1a1fcffd3bb2.png"> Closes facebook#8530 Differential Revision: D3515242 Pulled By: JoelMarcey fbshipit-source-id: c2d241d472853dfb3f9e7d3ae9560b318aacb866
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: We did a survey prior to the doc lockdown to get an idea of what we should focus on. Now we have a yes/no style survey to ensure that we met the user needs when it came to our start of improving the docs. This diff adds the survey link to the bottom of each page. And we will cherry-pick it into 0.29 as well, which will be the first official release with the new doc content > **NOTE**: The content via the links in this survey will not be valid until 0.29 is actually released. So I have not enabled the questions for the survey until then. **Test Plan:** http://localhost:8079/react-native/docs/getting-started.html <img width="753" alt="screenshot 2016-07-01 17 35 17" src="https://cloud.githubusercontent.com/assets/3757713/16535354/987dd3a8-3fb4-11e6-81b7-1a1fcffd3bb2.png"> Closes facebook/react-native#8530 Differential Revision: D3515242 Pulled By: JoelMarcey fbshipit-source-id: c2d241d472853dfb3f9e7d3ae9560b318aacb866
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did a survey prior to the doc lockdown to get an idea of what we should focus on. Now we have a yes/no style survey to ensure that we met the user needs when it came to our start of improving the docs.
This diff adds the survey link to the bottom of each page. And we will cherry-pick it into 0.29 as well, which will be the first official release with the new doc content
Test Plan:
http://localhost:8079/react-native/docs/getting-started.html