Added Pins (MKPointAnnotations) to map #867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: (32 commits) Update React.podspec Move libicucore to RCTWebSocketDebugger subspec Update React.podspec fix website Fix "next" link on NativeModules Add a comment about Live Reload Add screenshots to make it clearer Fix typo [ReactNative][Docs] Document how to link libraries Added #content hash to debugging link so that it scrolls to start of text on mobile Added tip to configure 'Pause On Caught Exceptions' flag Add basic documentation for debugging react native apps Add f8 video, changelog and jsjabber 0.3.1 Bring back accidentally reverted changes from 89fc8a4 Autobuild website on Travis Revert searches to SearchScreen.js - merging internally Fix typo and add comments to the example app Update tutorial - use sample data Remove blocked rotten tomatoes api key ...
…e/map-with-pins * 'master' of github.com:facebook/react-native: Fix Objective-C example in README Add '#content' to link Link to troubleshooting from getting started page Fix docs links wrong javascript in example Update NativeModulesIOS.md Add import RCTBridge.h for event sending example Fix broken link Fixed typo in tutorial (fix typo) Debugging.md Copy fix: Asyncronously -> Asynchronously Update GettingStarted.md Add recurring issues for troubleshooting Add note for hardware keyboard in simulator corrects typo in NativeModulesIOS README Add possessive case to React Adding the 'running the examples' instructions to the end of the README.md Adjust the plurality of goal to goals
…e/map-with-pins # By Christopher Chedeau (77) and others # Via Christopher Chedeau (32) and others * 'master' of github.com:facebook/react-native: (565 commits) [ReactNative] Use a single DisplayLink held by the bridge Replace ES6Promise with Promise MapView to support MKPointAnnotation using new attribute annotate in Map... [ReactNative] Move image asset loading to a queue Fix typo in NativeModulesIOS.md [react-packager] Add Array.prototype.es6 polyfill Fix typo in PanResponder documentation [Bridge] `RCT_REMAP_METHOD(js_name, selector)` [react-packager] Support @nx resolution postfix for assets Add flowconfig to SampleApp [ReactNative] allow running JS app server for Android from fbobjc [react-packager] Update sane to get windows fixes (and others) change to git clone https://github.com/facebook/react-native.git React Native: Sync Transforms and Enable Trailing Commas React Native: Add String.prototyp.es6 Polyfill [ReactNative] Fix logging React Native: Fix InteractionManager Race Condition [ipasize][ReactKit] Begin to ensmallen RCTConvert [ReactNative] Reverted D1986572 [ReactNative] Make RCTRootView propage motions ... # Conflicts: # React/Views/RCTMap.m # React/Views/RCTMapManager.m
facebook-github-bot
added
the
CLA Signed
|
The tests seem to be aborted due to a timeout, would it be possible to run the build again? |
|
How are pins different from annotations? They seem to be duplicating the same concept... |
|
I checked it, they are the same, I was simply too slow implementing this. Thanks for your help |
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
- Updated render function to reflect modern standard - Replaced var with const
This was referenced Sep 15, 2021
acoates-ms
added a commit
to acoates-ms/react-native
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I couldn't find more documentation / tests for the annotations, I assumed that there are no points where I should have added documentation / tests. Closes #276