Accept number for size prop in ActivityIndicator #8846

fadils · 2016-07-17T09:44:29Z

motivation

Previously, size can only accept either 'small' or 'large'. And to obtain a custom size, scale transformation is used. This is to let users to possibly pass number value directly to define ActivityIndicator's size.

Test plan

I have also modified the current example to reflect the new size prop in action.

ghost · 2016-07-17T09:46:44Z

By analyzing the blame information on this pull request, we identified @janicduplessis and @javache to be potential reviewers.

ghost · 2016-07-17T09:46:44Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

eslint-bot · 2016-07-17T09:50:02Z

Examples/UIExplorer/js/ActivityIndicatorExample.js

-            size="large"
-            color="#aa3300"
+            size='large'
+            color='#aa3300'
          />


jsx-quotes: Unexpected usage of singlequote.

ghost · 2016-07-17T09:55:57Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

eslint-bot · 2016-07-17T10:25:22Z

Examples/UIExplorer/js/ActivityIndicatorExample.js

+    }
+  },
+  {
+    title: 'Custom size (size: 30, scale transform: 1.5)',
    render() {
      return (
        <ActivityIndicator
          style={[styles.centering, {transform: [{scale: 1.5}]}]}


number This type is incompatible with string

chirag04 · 2016-07-17T12:52:41Z

Libraries/Components/ActivityIndicator/ActivityIndicator.js

-          styleAttr="Normal"
-          indeterminate
-        />
+        {ReturnedActivityIndicator}


you don't need to conditionally set the RCTActivityIndicator. just setting the right sizeStyle variable should be enough

thanks @chirag04 !

eslint-bot · 2016-07-17T14:01:04Z

Examples/UIExplorer/js/ActivityIndicatorExample.js

@@ -56,7 +56,7 @@ const ToggleAnimatingActivityIndicator = React.createClass({
      <ActivityIndicator
        animating={this.state.animating}
        style={[styles.centering, {height: 80}]}
-        size="large"
+        size='large'


jsx-quotes: Unexpected usage of singlequote.

eslint-bot · 2016-07-17T14:55:47Z

Examples/UIExplorer/js/ActivityIndicatorExample.js

+      return (
+        <ActivityIndicator
+          style={styles.centering}
+          size={48}


number This type is incompatible with string

Previously, size can only accept either 'small' or 'large'. And to obtain a custom size, scale transformation is used. This is to let users to possibly pass number value to define ActivityIndicator's size.

eslint-bot · 2016-07-21T01:51:05Z

Libraries/StyleSheet/IndicatorSizePropType.js

+  var size = props[propName];
+
+  if (size !== undefined && size !== null && typeof size !== 'number' && size !== 'small' && size !== 'large') {
+    var locationName = ReactPropTypeLocationNames[location];


no-unused-vars: 'locationName' is defined but never used

ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 17, 2016

eslint-bot reviewed Jul 17, 2016
View reviewed changes

fadils force-pushed the ActivityIndicator/add-size-prop branch from 7b5970f to 0b4d00f Compare July 17, 2016 10:20

eslint-bot reviewed Jul 17, 2016
View reviewed changes

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2016

fadils changed the title ~~Activity indicator/add size prop~~ Accept number for size prop in ActivityIndicator Jul 17, 2016