Add JS library for requesting Android M Permissions #9292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @caabernathy and @lacker to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
|
Great job, it sounds good! Can you add screenshots of the documentation ? |
|
Would be awesome if you could send a follow-up PR changing callbacks to promises. |
|
@satya164 will do! |
|
@cmcewen updated the pull request. |
| @@ -98,6 +98,7 @@ const ReactNative = { | |||
| get NavigationExperimental() { return require('NavigationExperimental'); }, | |||
| get NetInfo() { return require('NetInfo'); }, | |||
| get PanResponder() { return require('PanResponder'); }, | |||
| get PermissionsAndroid() { return require('PermissionsAndroid')}, | |||
| get PixelRatio() { return require('PixelRatio'); }, | |||
ghost
added
the
CLA Signed
|
@cmcewen updated the pull request. |
ghost
added
the
CLA Signed
|
Nice work @cmcewen! Stoked to see this one land. |
ghost
added
the
CLA Signed
|
@cmcewen updated the pull request. |
1 similar comment
|
@cmcewen updated the pull request. |
ghost
added
the
CLA Signed
ghost
added
the
CLA Signed
|
Seems good to me, but I'd like @andreicoman11 to look at it since he wrote the permissions module piece. |
ghost
added
the
CLA Signed
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing.If you are an FB employee go to Phabricator to review internal test results. |
ghost
added
the
CLA Signed
cmcewen
added a commit
to cmcewen/react-native
that referenced
this pull request
Aug 15, 2016
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Explain the **motivation** for making this change. What existing problem does the pull request solve? The Android permissions native module was open sourced recently (facebook@b7352b4) but it is currently undocumented and requires directly interfacing with the native module. This provides a JS wrapper to make it easier to use the permissions module and documents it. This could be cleaner if the native code used Promise blocks instead of callbacks, but I didn't want to change the native code without a thumbs up since I'm guessing this is used in one of facebook's apps. Happy to do that if it makes sense I also tried to make the `PERMISSIONS` object a class property - it works in the actual code but not in the documentation (think it's a jsdocs problem), so decided to initialize in the constructor. **Test plan (required)** If the API looks good, I will change the UIExplorer example to use this. cc andreicoman11 Closes facebook#9292 Differential Revision: D3716303 Pulled By: andreicoman11 fbshipit-source-id: cd40b8757fdf70ea8faecfb58caa00e99a99789e
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Aug 25, 2016
Summary: Explain the **motivation** for making this change. What existing problem does the pull request solve? The Android permissions native module was open sourced recently (facebook/react-native@b7352b4) but it is currently undocumented and requires directly interfacing with the native module. This provides a JS wrapper to make it easier to use the permissions module and documents it. This could be cleaner if the native code used Promise blocks instead of callbacks, but I didn't want to change the native code without a thumbs up since I'm guessing this is used in one of facebook's apps. Happy to do that if it makes sense I also tried to make the `PERMISSIONS` object a class property - it works in the actual code but not in the documentation (think it's a jsdocs problem), so decided to initialize in the constructor. **Test plan (required)** If the API looks good, I will change the UIExplorer example to use this. cc andreicoman11 Closes facebook/react-native#9292 Differential Revision: D3716303 Pulled By: andreicoman11 fbshipit-source-id: cd40b8757fdf70ea8faecfb58caa00e99a99789e
|
is this available in RN 0.37? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the motivation for making this change. What existing problem does the pull request solve?
The Android permissions native module was open sourced recently (b7352b4) but it is currently undocumented and requires directly interfacing with the native module.
This provides a JS wrapper to make it easier to use the permissions module and documents it.
This could be cleaner if the native code used Promise blocks instead of callbacks, but I didn't want to change the native code without a thumbs up since I'm guessing this is used in one of facebook's apps. Happy to do that if it makes sense
I also tried to make the
PERMISSIONSobject a class property - it works in the actual code but not in the documentation (think it's a jsdocs problem), so decided to initialize in the constructor.Test plan (required)
If the API looks good, I will change the UIExplorer example to use this.
cc @andreicoman11