Added name of the file with camera roll pictures #9961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React native camera roll library doesn't deliver the name. However, it is sometimes important especially the when the photo needs to be uploaded using multipart form upload. This change has added the name parameter with the image as well.
ghost
added
GH Review: review-needed
CLA Signed
|
How do you feel about calling this field |
|
@majak changed name to filename |
|
@mdrmuhaimin updated the pull request - view changes |
1 similar comment
|
@mdrmuhaimin updated the pull request - view changes |
ghost
added
the
CLA Signed
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
ghost
added
the
CLA Signed
bartolkaruza
pushed a commit
to bartolkaruza/react-native-cameraroll
that referenced
this pull request
Feb 24, 2019
Summary: Added name parameter when delivering the camera roll images using react native CameraRoll library. Based on http://stackoverflow.com/questions/37283976/react-native-get-photo-name-from-camera-roll-ios Closes facebook/react-native#9961 Differential Revision: D3883582 Pulled By: majak fbshipit-source-id: 5bfd1eb0601b3ce2ef1cdb4485060661d2fbad32
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added name parameter when delivering the camera roll images using react native CameraRoll library. Based on http://stackoverflow.com/questions/37283976/react-native-get-photo-name-from-camera-roll-ios